Review main Merged

90224[TASK] Resolve various ignored `nullCoalesce.offset` PHPStan errors

Elias Häußler CR +2 V +2 Normal +32 −171 updated 08/12/25, 20:32

Commit message

Several PHPStan errors with error identifier `nullCoalesce.offset` are
now resolved, if the appropriate implementation could be easily
adapted. Some leftovers remain in the baseline file, since their
resolution cannot be performed without further (potentially breaking)
type hardenings.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 79

  1. Elias Häußler uploaded patch set 1 08/01/25, 18:15

  2. core-ci voted on patch set 1 V +1 08/01/25, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82644

  3. Oliver Klee updated the commit message in patch set 2 V +1 08/02/25, 08:24

  4. core-ci voted on patch set 2 V +1 08/02/25, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82664

  5. Nikita Hovratov voted on patch set 2 CR +1 V +1 08/02/25, 16:15

  6. Oliver Klee voted on patch set 2 CR +1 V +1 08/03/25, 07:57

  7. Andreas Kienast voted on patch set 2 CR +1 08/04/25, 12:56

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 08/12/25, 20:25

  9. Christian Kuhn merged patch set 3 08/12/25, 20:32