90226[TASK] Add functional tests for Extbase FileUpload
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Georg Ringer +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 6
- Task #107197Create functional tests for Extbase file uploads
- Bug #107198Uploading EXE files fails MIME Resource Integrity
- Task #107033Add more mime type mappings for common files
- Epic #106772Streamline May 2025 security releases (collection issue)
- Task #107191Enhance Extbase file upload handling
- Bug #107142Skipping consistency check in \TYPO3\CMS\Core\Resource\ResourceStorage::addUploadedFile fails
Files 36
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Classes/Controller/SingleFileUploadController.phpnew+82 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Classes/Domain/Model/Singlefile.phpnew+335 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Classes/Domain/Repository/SinglefileRepository.phpnew+31 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Configuration/Form/Definitions/Uploads.form.yamlnew+44 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Configuration/Form/FormSetup.yamlnew+6 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Configuration/TCA/Overrides/tt_content.phpnew+11 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Configuration/TCA/tx_extbaseupload_domain_model_singlefile.phpnew+259 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Configuration/TypoScript/Frontend/setup.typoscriptnew+21 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Configuration/TypoScript/setup.typoscriptnew+22 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Configuration/Services.yaml4new+9 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Resources/Private/Layouts/Default.htmlnew+12 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Resources/Private/Partials/SinglefileFormfields.htmlnew+156 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Resources/Private/Templates/SingleFileUpload/Edit.htmlnew+13 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Resources/Private/Templates/SingleFileUpload/List.htmlnew+20 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Resources/Private/Templates/SingleFileUpload/New.htmlnew+13 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Resources/Private/Templates/SingleFileUpload/Show.htmlnew+8 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Resources/Public/Icons/Extension.svgnew+1 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/composer.jsonnew+19 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/ext_emconf.phpnew+21 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/ext_localconf.phpnew+28 −0
Show 16 more files
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Uploads/test-is-exe.txtnewbinary
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Uploads/test-is-jpg.exenewbinary
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Uploads/test-is-jpg.txtnewbinary
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Uploads/test-is-pdf.txtnewbinary
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Uploads/test-is-webp.jpgnewbinary
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Uploads/test.exenewbinary
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Uploads/test.htmlnew+5 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Uploads/test.jpgnewbinary
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Uploads/test.pdfnewbinary
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Uploads/test.phpnew+35 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Uploads/test.txtnew+1 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Uploads/test.webpnewbinary
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Uploads/test.xmlnew+4 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/FileUploadData.csvnew+10 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/FileUploadControllerTest.php1new+616 −0
- composer.json+1 −0
Review log 4468
Show 2443 earlier messages
-
Garvin Hicking uploaded patch set 1 08/02/25, 18:52
-
core-ci voted on patch set 1 V -1 08/02/25, 19:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82672
-
Garvin Hicking uploaded patch set 2
V -108/02/25, 19:20 -
core-ci voted on patch set 2 V -1 08/02/25, 19:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82673
-
Garvin Hicking uploaded patch set 3
V -108/02/25, 19:37 -
core-ci voted on patch set 3 V -1 08/02/25, 19:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82674
-
Garvin Hicking uploaded patch set 4
V -108/02/25, 20:03 -
core-ci voted on patch set 4 V +1 08/02/25, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82675
-
Garvin Hicking uploaded patch set 5
V +108/02/25, 20:23 -
core-ci voted on patch set 5 V -1 08/02/25, 20:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82676
-
Garvin Hicking uploaded patch set 6
V -108/02/25, 20:51 -
core-ci voted on patch set 6 V -1 08/02/25, 21:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82677
-
Garvin Hicking uploaded patch set 7
V -108/02/25, 22:10 -
core-ci voted on patch set 7 V -1 08/02/25, 22:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82678
-
Garvin Hicking uploaded patch set 8
V -108/03/25, 08:49 -
core-ci voted on patch set 8 V +1 08/03/25, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82694
-
Garvin Hicking uploaded patch set 9
V +108/03/25, 16:58 -
core-ci voted on patch set 9 V -1 08/03/25, 17:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82695
-
Garvin Hicking uploaded patch set 10
V -108/03/25, 17:36 -
core-ci voted on patch set 10 V +1 08/03/25, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82696
-
Garvin Hicking uploaded patch set 11
V +108/03/25, 19:27 -
core-ci voted on patch set 11 V +1 08/03/25, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82697
-
Garvin Hicking uploaded patch set 12
V +109/10/25, 13:31 -
Garvin Hicking uploaded patch set 13 09/10/25, 13:32
-
core-ci voted on patch set 12 V -1 09/10/25, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84780
-
core-ci voted on patch set 13 V -1 09/10/25, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84781
-
Garvin Hicking uploaded patch set 14
V -109/10/25, 14:21 -
core-ci voted on patch set 14 V -1 09/10/25, 14:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84787
-
Garvin Hicking rebased onto patch set 15
V -109/12/25, 15:32 -
core-ci voted on patch set 15 V +1 09/12/25, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84923
-
Garvin Hicking rebased onto patch set 16
V +109/27/25, 19:09 -
core-ci voted on patch set 16 V -1 09/27/25, 19:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85648
-
Garvin Hicking rebased onto patch set 17
V -109/29/25, 16:09 -
core-ci voted on patch set 17 V +1 09/29/25, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85700
-
Garvin Hicking rebased onto patch set 18
V +110/28/25, 11:57 -
Christian Kuhn uploaded patch set 19 10/28/25, 12:07
-
core-ci voted on patch set 18 V -1 10/28/25, 12:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87812
-
core-ci voted on patch set 19 V +1 10/28/25, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87814
-
Christian Kuhn commented on patch set 19 CR -1 10/28/25, 12:26
on it. -
Christian Kuhn commented on patch set 19 10/28/25, 12:28
FileUploadControllerTest.php:72we don't need to do this since that file is written to typo3temp/var/tests/functional-... - it does not pollute monorepo itself and file_put_contents() overrides it with a fresh file for each test. -
Christian Kuhn uploaded patch set 20
CR -1V +110/28/25, 12:54 -
Christian Kuhn commented on patch set 20 10/28/25, 12:58
i tried to streamline minor details, being as simple as possible and as complex as needed. i think this set of tests could become an important whistleblower with extbase, and could be an indicator on the stability of our API's depending on how often we have to change things in it. let's see how it evolves. -
Christian Kuhn uploaded patch set 21 10/28/25, 12:58
-
core-ci voted on patch set 20 V -1 10/28/25, 13:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87819
-
core-ci voted on patch set 21 V +1 10/28/25, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87820
-
Christian Kuhn uploaded patch set 22
V +110/28/25, 16:06 -
Christian Kuhn voted on patch set 22 CR +1 V +1 10/28/25, 16:06
-
core-ci voted on patch set 22 V +1 10/28/25, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87857
-
Oliver Klee voted on patch set 22 V +1 10/28/25, 16:38
-
Garvin Hicking commented on patch set 22 10/28/25, 19:15
Thanks lolli, changes are fine by me! -
Stefan Bürk commented on patch set 22 10/28/25, 19:33
Services.yaml:9Why is `Domain/Validator/` excluded here ? The test fixture extension does not provide any validators. On the otherside, is that not considerable bad practice - would that not prevent validator DI if marked as excluded ? https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ExtensionArchitecture/Extbase/Reference/Validation/CustomValidator/Index.html#extbase-domain-validator-di -
Christian Kuhn uploaded patch set 23
CR +1V +110/28/25, 20:17 -
Christian Kuhn commented on patch set 22 CR +1 V +1 10/28/25, 20:17
Services.yaml:9ReplyDone -
Christian Kuhn voted on patch set 23 CR +1 V +1 10/28/25, 20:17
-
Anja Leichsenring voted on patch set 23 CR +1 V +1 10/28/25, 20:18
-
Stefan Bürk voted on patch set 23 CR +1 V +1 10/28/25, 20:19
-
core-ci voted on patch set 23 V +1 10/28/25, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87884
-
Garvin Hicking commented on patch set 23 10/28/25, 20:26
Services.yaml:9ReplyThanks. Indeed this is boilerplate code that should be removed. Waa copied over by another exampme extension. -
Garvin Hicking voted on patch set 23 CR +2 V +2 10/28/25, 20:30
-
Stefan Bürk commented on patch set 23 10/28/25, 20:30
Services.yaml:9ReplyDone -
Garvin Hicking commented on patch set 23 CR 0 V 0 10/28/25, 21:06
working on v13 backport before merging, please hold yer vote horses -
Garvin Hicking updated the commit message in patch set 24
CR +1V +110/28/25, 21:40 -
Garvin Hicking commented on patch set 24 10/28/25, 21:41
Reply
Changing scope to main only, because: https://review.typo3.org/c/Packages/TYPO3.CMS/+/89983 was a hidden dependency of this set of tests. PSR file uploads cannot easily be functionally tested without it. It makes to sense to jump through hoops to make it work in v13, so let's go forward from main only. -
Stefan Bürk voted on patch set 24 CR +1 V +1 10/28/25, 21:46
-
core-ci voted on patch set 24 V +1 10/28/25, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87892
-
Christian Kuhn voted on patch set 24 CR +1 V +1 10/28/25, 22:53
-
Georg Ringer voted on patch set 24 CR +2 V +2 10/29/25, 06:35
-
Georg Ringer merged patch set 25 10/29/25, 06:35