Review main Merged

90226[TASK] Add functional tests for Extbase FileUpload

Garvin Hicking CR +2 V +2 Expert +1783 −0 updated 10/29/25, 06:35

Commit message

Implement a test matrix as a functional test, looking at
"real" file uploads in Extbase FE site context using sub
requests.

The test scenario is quite complex and touches many systems
like significant parts of FE rendering and various extbase
mechanics. It may become a good whistleblower when patches
break things in a wider overall FE range.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 6

Files 36

Show 16 more files

Review log 4468

Show 2443 earlier messages
  1. Garvin Hicking uploaded patch set 1 08/02/25, 18:52

  2. core-ci voted on patch set 1 V -1 08/02/25, 19:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82672

  3. Garvin Hicking uploaded patch set 2 V -1 08/02/25, 19:20

  4. core-ci voted on patch set 2 V -1 08/02/25, 19:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82673

  5. Garvin Hicking uploaded patch set 3 V -1 08/02/25, 19:37

  6. core-ci voted on patch set 3 V -1 08/02/25, 19:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82674

  7. Garvin Hicking uploaded patch set 4 V -1 08/02/25, 20:03

  8. core-ci voted on patch set 4 V +1 08/02/25, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82675

  9. Garvin Hicking uploaded patch set 5 V +1 08/02/25, 20:23

  10. core-ci voted on patch set 5 V -1 08/02/25, 20:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82676

  11. Garvin Hicking uploaded patch set 6 V -1 08/02/25, 20:51

  12. core-ci voted on patch set 6 V -1 08/02/25, 21:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82677

  13. Garvin Hicking uploaded patch set 7 V -1 08/02/25, 22:10

  14. core-ci voted on patch set 7 V -1 08/02/25, 22:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82678

  15. Garvin Hicking uploaded patch set 8 V -1 08/03/25, 08:49

  16. core-ci voted on patch set 8 V +1 08/03/25, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82694

  17. Garvin Hicking uploaded patch set 9 V +1 08/03/25, 16:58

  18. core-ci voted on patch set 9 V -1 08/03/25, 17:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82695

  19. Garvin Hicking uploaded patch set 10 V -1 08/03/25, 17:36

  20. core-ci voted on patch set 10 V +1 08/03/25, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82696

  21. Garvin Hicking uploaded patch set 11 V +1 08/03/25, 19:27

  22. core-ci voted on patch set 11 V +1 08/03/25, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82697

  23. Garvin Hicking uploaded patch set 12 V +1 09/10/25, 13:31

  24. Garvin Hicking uploaded patch set 13 09/10/25, 13:32

  25. core-ci voted on patch set 12 V -1 09/10/25, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84780

  26. core-ci voted on patch set 13 V -1 09/10/25, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84781

  27. Garvin Hicking uploaded patch set 14 V -1 09/10/25, 14:21

  28. core-ci voted on patch set 14 V -1 09/10/25, 14:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84787

  29. Garvin Hicking rebased onto patch set 15 V -1 09/12/25, 15:32

  30. core-ci voted on patch set 15 V +1 09/12/25, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84923

  31. Garvin Hicking rebased onto patch set 16 V +1 09/27/25, 19:09

  32. core-ci voted on patch set 16 V -1 09/27/25, 19:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85648

  33. Garvin Hicking rebased onto patch set 17 V -1 09/29/25, 16:09

  34. core-ci voted on patch set 17 V +1 09/29/25, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85700

  35. Garvin Hicking rebased onto patch set 18 V +1 10/28/25, 11:57

  36. Christian Kuhn uploaded patch set 19 10/28/25, 12:07

  37. core-ci voted on patch set 18 V -1 10/28/25, 12:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87812

  38. core-ci voted on patch set 19 V +1 10/28/25, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87814

  39. Christian Kuhn commented on patch set 19 CR -1 10/28/25, 12:26

    on it.
  40. Christian Kuhn commented on patch set 19 10/28/25, 12:28

    FileUploadControllerTest.php:72

    we don't need to do this since that file is written to typo3temp/var/tests/functional-... - it does not pollute monorepo itself and file_put_contents() overrides it with a fresh file for each test.
  41. Christian Kuhn uploaded patch set 20 CR -1 V +1 10/28/25, 12:54

  42. Christian Kuhn commented on patch set 20 10/28/25, 12:58

    i tried to streamline minor details, being as simple as possible and as complex as needed. i think this set of tests could become an important whistleblower with extbase, and could be an indicator on the stability of our API's depending on how often we have to change things in it. let's see how it evolves.
  43. Christian Kuhn uploaded patch set 21 10/28/25, 12:58

  1. core-ci voted on patch set 20 V -1 10/28/25, 13:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87819

  2. core-ci voted on patch set 21 V +1 10/28/25, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87820

  3. Christian Kuhn uploaded patch set 22 V +1 10/28/25, 16:06

  4. Christian Kuhn voted on patch set 22 CR +1 V +1 10/28/25, 16:06

  5. core-ci voted on patch set 22 V +1 10/28/25, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87857

  6. Oliver Klee voted on patch set 22 V +1 10/28/25, 16:38

  7. Garvin Hicking commented on patch set 22 10/28/25, 19:15

    Thanks lolli, changes are fine by me!
  8. Stefan Bürk commented on patch set 22 10/28/25, 19:33

    Services.yaml:9

    Why is `Domain/Validator/` excluded here ? The test fixture extension does not provide any validators. On the otherside, is that not considerable bad practice - would that not prevent validator DI if marked as excluded ? https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ExtensionArchitecture/Extbase/Reference/Validation/CustomValidator/Index.html#extbase-domain-validator-di
  9. Christian Kuhn uploaded patch set 23 CR +1 V +1 10/28/25, 20:17

  10. Christian Kuhn commented on patch set 22 CR +1 V +1 10/28/25, 20:17

    Services.yaml:9 Reply

    Done
  11. Christian Kuhn voted on patch set 23 CR +1 V +1 10/28/25, 20:17

  12. Anja Leichsenring voted on patch set 23 CR +1 V +1 10/28/25, 20:18

  13. Stefan Bürk voted on patch set 23 CR +1 V +1 10/28/25, 20:19

  14. core-ci voted on patch set 23 V +1 10/28/25, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87884

  15. Garvin Hicking commented on patch set 23 10/28/25, 20:26

    Services.yaml:9 Reply

    Thanks. Indeed this is boilerplate code that should be removed. Waa copied over by another exampme extension.
  16. Garvin Hicking voted on patch set 23 CR +2 V +2 10/28/25, 20:30

  17. Stefan Bürk commented on patch set 23 10/28/25, 20:30

    Services.yaml:9 Reply

    Done
  18. Garvin Hicking commented on patch set 23 CR 0 V 0 10/28/25, 21:06

    working on v13 backport before merging, please hold yer vote horses
  19. Garvin Hicking updated the commit message in patch set 24 CR +1 V +1 10/28/25, 21:40

  20. Garvin Hicking commented on patch set 24 10/28/25, 21:41

    Reply

    Changing scope to main only, because: https://review.typo3.org/c/Packages/TYPO3.CMS/+/89983 was a hidden dependency of this set of tests. PSR file uploads cannot easily be functionally tested without it. It makes to sense to jump through hoops to make it work in v13, so let's go forward from main only.
  21. Stefan Bürk voted on patch set 24 CR +1 V +1 10/28/25, 21:46

  22. core-ci voted on patch set 24 V +1 10/28/25, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87892

  23. Christian Kuhn voted on patch set 24 CR +1 V +1 10/28/25, 22:53

  24. Georg Ringer voted on patch set 24 CR +2 V +2 10/29/25, 06:35

  25. Georg Ringer merged patch set 25 10/29/25, 06:35