90227[BUGFIX] Fix default value of TYPO3_CONF_VARS/BE/lockRootPath
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Oliver Klee +1
- Markus Klein +1
- Garvin Hicking +1
- Peter Kraume +1
-
Verified V +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Oliver Klee +1
- Markus Klein +1
- Garvin Hicking +1
- Peter Kraume +1
- core-ci +1 CI
Issues 2
Files 1
Review log 2732
Show 67 earlier messages
-
Albrecht Köhnlein uploaded patch set 1 08/04/25, 06:57
-
core-ci voted on patch set 1 V +1 08/04/25, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82720
-
Peter Kraume voted on patch set 1 CR +1 V +1 08/04/25, 07:46
-
Markus Klein voted on patch set 1 CR +1 V +1 08/04/25, 08:55
-
Oliver Klee voted on patch set 1 CR +1 V +1 08/04/25, 09:02
-
Oliver Klee commented on patch set 1 08/04/25, 09:08
Should we also add a link to the docs? https://docs.typo3.org/permalink/t3coreapi:confval-globals-typo3-conf-vars-be-lockrootpathShould we also fix this for 12.4 (which also is affected)? -
Albrecht Köhnlein updated the commit message in patch set 2
CR +1V +108/04/25, 09:17
-
Albrecht Köhnlein updated the commit message in patch set 3 08/04/25, 09:19
-
Albrecht Köhnlein commented on patch set 3 08/04/25, 09:20
Reply
I found the changelog entry and added a link to it. I think it's even better than a link to the documentation in this case.Reply
Thanks. You're right. -
core-ci voted on patch set 2 V +1 08/04/25, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82728
-
core-ci voted on patch set 3 V +1 08/04/25, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82729
-
Oli Bartsch commented on patch set 3 08/04/25, 09:29
I fail to reproduce this error. Can you give me some advice where this fails? -
Oliver Hader commented on patch set 3 08/04/25, 09:29
I'm just testing the other way, having the default value as empty array `[]`, but some additional config trying to string concat. ``` <?php $config = [ 'lockRootPath' => [], ]; $config['lockRootPath'] .= 'first'; # $config['lockRootPath'][] = 'first'; var_dump($config); ``` This works, but has `'lockRootPath' => 'Arrayfirst'`. I think it would have been better (back then) to introduce a new `lockRootPaths` (plural) and phase out the original `lockRootPath` (singular). -
Oliver Klee updated the commit message in patch set 4
V +108/04/25, 09:31 -
Oliver Klee voted on patch set 4 CR +1 V +1 08/04/25, 09:31
-
Garvin Hicking updated the commit message in patch set 5
CR +1V +108/04/25, 09:35 -
Oliver Klee voted on patch set 5 CR +1 V +1 08/04/25, 09:37
-
Albrecht Köhnlein commented on patch set 4 08/04/25, 09:38
Reply
What would you recommend? Remove the compatibilty fallback in https://github.com/TYPO3/typo3/blob/e1e0ce8e3059d1910dd6f3ed8443c27b6c6d12d1/typo3/sysext/core/Classes/Utility/PathUtility.php#L463 and make this a breaking change instead of a bugfix?Reply
I simply need to add ```$GLOBALS['TYPO3_CONF_VARS']['BE']['lockRootPath'][] = '/path/to/shared';``` into my `system/additional.php` file to run into this error. -
core-ci voted on patch set 4 V +1 08/04/25, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82731
-
Garvin Hicking commented on patch set 5 08/04/25, 09:42
Reply
Would someone do string concatenation on it? In the string variant, only a single path was allowed... so I would argue this usescase might not happen in reality? (agreed on "lockRootPaths" having been better - but switching to array completely sounds good to me, unsure about the v12 backport though tbh). -
core-ci voted on patch set 5 V +1 08/04/25, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82733
-
Oliver Hader commented on patch set 5 08/04/25, 10:37
Reply
I forgot, that only one path was allowed in the past. Thanks for pointing this out. I've added an overview matrix at https://forge.typo3.org/issues/107199#note-13 Thus, I don't see any aspects, how the patch above might introduce an additional misbehavior → "looks good from my POV" -
Oliver Hader voted on patch set 5 CR +1 V +1 08/04/25, 11:24
-
Oli Bartsch commented on patch set 5 08/04/25, 11:27
Reply
All right, thanks. -
Oli Bartsch voted on patch set 5 CR +1 V +1 08/04/25, 11:28
-
Peter Kraume voted on patch set 5 CR +1 V +1 08/04/25, 11:34
-
Markus Klein voted on patch set 5 CR +1 V +1 08/04/25, 12:04
-
Garvin Hicking commented on patch set 5 CR +2 V +2 08/04/25, 12:13
Reply
I love your Matrix, that couldmve been me 😂 -
Garvin Hicking voted on patch set 5 CR +1 V +1 08/04/25, 12:13
-
Oliver Hader voted on patch set 5 CR +2 V +2 08/04/25, 14:04
-
Oliver Hader merged patch set 6 08/04/25, 14:05