Review main Merged

90230[FEATURE] Extend RSS widget with Atom feed support

Oli Bartsch CR +2 V +2 Normal +173 −12 updated 09/06/25, 13:35

Commit message

Extend the existing RSS widget in the TYPO3 dashboard
to automatically detect and parse both RSS and Atom
feed formats, providing unified feed support.

The widget now transparently handles Atom feeds
(RFC 4287) from platforms like GitHub for release
notifications while maintaining full backward
compatibility with existing RSS configurations.

The implementation includes separate parsing methods
for RSS and Atom formats with automatic format
detection, ensuring optimal handling of both feed types.

This enables users to display GitHub releases, GitLab
feeds, and other Atom-based content using the same
RSS widget with full configurability through the
dashboard interface.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 2128

Show 23 earlier messages
  1. Oli Bartsch uploaded patch set 1 08/04/25, 09:10

  2. core-ci voted on patch set 1 V -1 08/04/25, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82727

  3. Oli Bartsch uploaded patch set 2 V -1 08/04/25, 09:25

  1. core-ci voted on patch set 2 V -1 08/04/25, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82730

  2. Benjamin Franzke commented on patch set 2 08/04/25, 10:09

    As I user I would expect that RSS (which is common term for all kinds of web feeds) supports ATOM as well. Let's merge that into the existing implementation.
  3. Benjamin Kott commented on patch set 2 08/04/25, 10:10

    Reply

    +1
  4. Oli Bartsch commented on patch set 2 08/04/25, 10:47

    Reply

    Thought about this first but based on the different data, e.g. author information, theoretically multiple links, etc. I decided to make a dedicated widget implementation to avoid a lot of if/else. Also this makes documentation much easier and finally, we do not need to adjust existing labels. If we merge this how should the distinction happen? Based on user settings or based on evaluating the fetched feed content for specific patterns?
  5. Oli Bartsch uploaded patch set 3 V -1 08/04/25, 10:48

  6. core-ci voted on patch set 3 V +1 08/04/25, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82749

  7. Benjamin Franzke commented on patch set 3 08/04/25, 11:31

    Reply

    I don't see documentation issues when RSS widget (which could be made an alias to a more generic `FeedWidget` if really needed for the sake of generic code) supports two formats, as I said, RSS is the common term that – from a user perspective – does not care about if it's technically actually a RSS feed or an ATOM feed. That means existing labels can stay as-is. > Based on user settings or based on evaluating the fetched feed content for specific patterns As a user I expect that the system can detect ATOM vs RSS. That means we should add two internal handlers, which are dispatched via runtime XML response format detection. Once we receive the XML result from the server, we can detect whether it's atom and dispatch to the ATOM parser and otherwise use RSS. So don't make that a line-by-line feature detection, but have two data processors.
  8. Garvin Hicking commented on patch set 3 08/04/25, 13:50

    Reply

    Just to chime in: I initially thought the RSS widget would also read atom feeds when testing the new widgets. I would not expect to need to choose between two different widgets. This would also allow to update an existing widget when the provider changes from rss to atom.
  9. Oli Bartsch uploaded patch set 4 V +1 08/09/25, 08:20

  10. core-ci voted on patch set 4 V +1 08/09/25, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83050

  11. Oli Bartsch uploaded patch set 5 V +1 08/09/25, 08:28

  12. Oli Bartsch commented on patch set 5 08/09/25, 08:29

    Reply

    You've convinced me. I might looked to technically on this. Will update after the dev days, if nobody updates this during coding night. 🫣
  13. Georg Ringer commented on patch set 5 CR +1 V +1 08/09/25, 08:35

    tested with https://www.golem.de/sonstiges/rss.html feeds, thanks a lot!
  14. core-ci voted on patch set 5 V +1 08/09/25, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83051

  15. Garvin Hicking commented on patch set 5 08/09/25, 09:04

    Reply

    Nice, thanks! This looks quite good, only the html_entity_decode() things inspire me to do some in-depth testing 😇
  16. Oli Bartsch uploaded patch set 6 CR +1 V +1 08/09/25, 09:27

  17. Oli Bartsch uploaded patch set 7 08/09/25, 09:28

  18. Oli Bartsch commented on patch set 7 08/09/25, 09:29

    Reply

    You're right. Let's tackle this in a separate patch.
  19. Garvin Hicking voted on patch set 7 CR +1 V +1 08/09/25, 09:29

  20. core-ci voted on patch set 6 V +1 08/09/25, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83057

  21. core-ci voted on patch set 7 V +1 08/09/25, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83058

  22. Georg Ringer voted on patch set 7 CR +1 V +1 08/09/25, 09:39

  23. Oli Bartsch voted on patch set 7 CR +2 V +2 08/10/25, 11:46

  24. Oli Bartsch merged patch set 8 08/10/25, 11:54

  25. Lina Wolf commented on patch set 8 09/06/25, 13:35

    Unresolved

    These changes still need to be documented in the extensions manual https://forge.typo3.org/issues/107407