90230[FEATURE] Extend RSS widget with Atom feed support
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Garvin Hicking +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 3
Review log 2128
Show 23 earlier messages
-
Oli Bartsch uploaded patch set 1 08/04/25, 09:10
-
core-ci voted on patch set 1 V -1 08/04/25, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82727
-
Oli Bartsch uploaded patch set 2
V -108/04/25, 09:25
-
core-ci voted on patch set 2 V -1 08/04/25, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82730
-
Benjamin Franzke commented on patch set 2 08/04/25, 10:09
As I user I would expect that RSS (which is common term for all kinds of web feeds) supports ATOM as well. Let's merge that into the existing implementation. -
Benjamin Kott commented on patch set 2 08/04/25, 10:10
Reply
+1 -
Oli Bartsch commented on patch set 2 08/04/25, 10:47
Reply
Thought about this first but based on the different data, e.g. author information, theoretically multiple links, etc. I decided to make a dedicated widget implementation to avoid a lot of if/else. Also this makes documentation much easier and finally, we do not need to adjust existing labels. If we merge this how should the distinction happen? Based on user settings or based on evaluating the fetched feed content for specific patterns? -
Oli Bartsch uploaded patch set 3
V -108/04/25, 10:48 -
core-ci voted on patch set 3 V +1 08/04/25, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82749
-
Benjamin Franzke commented on patch set 3 08/04/25, 11:31
Reply
I don't see documentation issues when RSS widget (which could be made an alias to a more generic `FeedWidget` if really needed for the sake of generic code) supports two formats, as I said, RSS is the common term that – from a user perspective – does not care about if it's technically actually a RSS feed or an ATOM feed. That means existing labels can stay as-is. > Based on user settings or based on evaluating the fetched feed content for specific patterns As a user I expect that the system can detect ATOM vs RSS. That means we should add two internal handlers, which are dispatched via runtime XML response format detection. Once we receive the XML result from the server, we can detect whether it's atom and dispatch to the ATOM parser and otherwise use RSS. So don't make that a line-by-line feature detection, but have two data processors. -
Garvin Hicking commented on patch set 3 08/04/25, 13:50
Reply
Just to chime in: I initially thought the RSS widget would also read atom feeds when testing the new widgets. I would not expect to need to choose between two different widgets. This would also allow to update an existing widget when the provider changes from rss to atom. -
Oli Bartsch uploaded patch set 4
V +108/09/25, 08:20 -
core-ci voted on patch set 4 V +1 08/09/25, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83050
-
Oli Bartsch uploaded patch set 5
V +108/09/25, 08:28 -
Oli Bartsch commented on patch set 5 08/09/25, 08:29
Reply
You've convinced me. I might looked to technically on this. Will update after the dev days, if nobody updates this during coding night. 🫣 -
Georg Ringer commented on patch set 5 CR +1 V +1 08/09/25, 08:35
tested with https://www.golem.de/sonstiges/rss.html feeds, thanks a lot! -
core-ci voted on patch set 5 V +1 08/09/25, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83051
-
Garvin Hicking commented on patch set 5 08/09/25, 09:04
Reply
Nice, thanks! This looks quite good, only the html_entity_decode() things inspire me to do some in-depth testing 😇 -
Oli Bartsch uploaded patch set 6
CR +1V +108/09/25, 09:27 -
Oli Bartsch uploaded patch set 7 08/09/25, 09:28
-
Oli Bartsch commented on patch set 7 08/09/25, 09:29
Reply
You're right. Let's tackle this in a separate patch. -
Garvin Hicking voted on patch set 7 CR +1 V +1 08/09/25, 09:29
-
core-ci voted on patch set 6 V +1 08/09/25, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83057
-
core-ci voted on patch set 7 V +1 08/09/25, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83058
-
Georg Ringer voted on patch set 7 CR +1 V +1 08/09/25, 09:39
-
Oli Bartsch voted on patch set 7 CR +2 V +2 08/10/25, 11:46
-
Oli Bartsch merged patch set 8 08/10/25, 11:54
-
Lina Wolf commented on patch set 8 09/06/25, 13:35
Unresolved
These changes still need to be documented in the extensions manual https://forge.typo3.org/issues/107407