Review main Merged

90233[BUGFIX] Respect rss widget limit set via options

Benjamin Kott CR +2 V +2 Easy +1 −1 updated 08/04/25, 12:53

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Benjamin Kott uploaded patch set 1 08/04/25, 10:17

  2. Benjamin Franzke voted on patch set 1 CR +1 V +1 08/04/25, 10:18

  3. core-ci voted on patch set 1 V +1 08/04/25, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82746

  4. Oli Bartsch commented on patch set 1 08/04/25, 10:43

    RssWidget.php:62

    This should also be configurable via options, right?
  5. Benjamin Franzke commented on patch set 1 08/04/25, 11:41

    RssWidget.php:62 Reply

    Was not intended, since the label falls back to the dashboard widget renderer title in this case. I think Benji's idea was to make `label` only configurable if `feedUrl` is not fixed (therefore line 65 set's this setting to readonly if `feedUrl` is given).
  6. Garvin Hicking voted on patch set 1 CR +1 V +1 08/04/25, 12:50

  7. Benjamin Kott commented on patch set 1 08/04/25, 12:51

    RssWidget.php:62 Reply

    yes, the widget result label will override the configured label, this is optional and does not need to be provided. If not provided it will take the label provided in the service registration. when the feedurl is provided through the options, there will also be likely a title and description be provided. otherwise it would not be differenciatable from other instances in the picker. to it´s directly attached to the registration and does not need to be available for configuration.
  8. Benjamin Kott voted on patch set 1 CR +2 V +2 08/04/25, 12:52

  9. Benjamin Kott merged patch set 2 08/04/25, 12:53