Review main Merged

90235[BUGFIX] Improve RSS widget error handling and user feedback

Oli Bartsch CR +2 V +2 Normal +88 −20 updated 08/09/25, 08:06

Commit message

Replace empty RSS widget display with proper messages when:

- No feed URL is configured
- Feed URL cannot be fetched or parsed
- Feed is valid but contains no items

This prevents users from seeing blank widgets,
or widgets with a "ERROR" content, but instead
provides clear feedback about current RSS feed
configuration issues.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1216

  1. Oli Bartsch uploaded patch set 1 08/04/25, 11:38

  2. core-ci voted on patch set 1 V +1 08/04/25, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82752

  3. Markus Klein commented on patch set 1 08/04/25, 12:03

    RssWidget.php:103

    why not simply `if ($feedUrl)` ? (The is-not-set-check part of `empty` is not relevant here)

    RssWidget.php:139

    why not passing on $e as "previous exception"?
  4. Oli Bartsch uploaded patch set 2 V +1 08/04/25, 12:12

  5. Oli Bartsch commented on patch set 2 08/04/25, 12:13

    RssWidget.php:103 Reply

    Done

    RssWidget.php:139 Reply

    What would be the use case? We catch the exception without evaluating the previous exception.
  6. core-ci voted on patch set 2 V +1 08/04/25, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82753

  7. Markus Klein commented on patch set 2 08/04/25, 19:14

    RssWidget.php:139 Reply

    No no, I meant as third param on the InvalidRssFeedException.
  8. Markus Klein commented on patch set 2 08/04/25, 19:15

    RssWidget.php:139

    Received
  9. Markus Klein commented on patch set 3 V +1 08/04/25, 19:16

    Published edit on patch set 2.
  10. Markus Klein commented on patch set 3 08/04/25, 19:16

    RssWidget.php:139 Reply

    Done

    RssWidget.php:139 Reply

    Done
  11. core-ci voted on patch set 3 V +1 08/04/25, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82767

  12. Markus Klein rebased onto patch set 4 V +1 08/07/25, 19:38

  13. core-ci voted on patch set 4 V +1 08/07/25, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82888

  14. Andreas Kienast voted on patch set 4 CR +1 V +1 08/08/25, 08:25

  15. Georg Ringer voted on patch set 4 CR +2 V +2 08/09/25, 08:06

  16. Georg Ringer merged patch set 5 08/09/25, 08:06