90235[BUGFIX] Improve RSS widget error handling and user feedback
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Andreas Kienast +1
-
Verified V +2 Done
- Georg Ringer +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/dashboard/Classes/Exception/InvalidRssFeedException.phpnew+22 −0
- typo3/sysext/dashboard/Classes/Widgets/RssWidget.php8+18 −6
- typo3/sysext/dashboard/Classes/DashboardEntry.php+1 −1
- typo3/sysext/dashboard/Resources/Private/Language/locallang_widget_rss.xlf+21 −0
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/RssWidget.html+26 −13
Review log 1216
-
Oli Bartsch uploaded patch set 1 08/04/25, 11:38
-
core-ci voted on patch set 1 V +1 08/04/25, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82752
-
Markus Klein commented on patch set 1 08/04/25, 12:03
RssWidget.php:139why not passing on $e as "previous exception"? -
Oli Bartsch uploaded patch set 2
V +108/04/25, 12:12 -
Oli Bartsch commented on patch set 2 08/04/25, 12:13
RssWidget.php:103ReplyDoneRssWidget.php:139ReplyWhat would be the use case? We catch the exception without evaluating the previous exception. -
core-ci voted on patch set 2 V +1 08/04/25, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82753
-
Markus Klein commented on patch set 2 08/04/25, 19:14
RssWidget.php:139ReplyNo no, I meant as third param on the InvalidRssFeedException. -
Markus Klein commented on patch set 2 08/04/25, 19:15
RssWidget.php:139Received -
Markus Klein commented on patch set 3
V +108/04/25, 19:16Published edit on patch set 2. -
Markus Klein commented on patch set 3 08/04/25, 19:16
RssWidget.php:139ReplyDoneRssWidget.php:139ReplyDone -
core-ci voted on patch set 3 V +1 08/04/25, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82767
-
Markus Klein rebased onto patch set 4
V +108/07/25, 19:38 -
core-ci voted on patch set 4 V +1 08/07/25, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82888
-
Andreas Kienast voted on patch set 4 CR +1 V +1 08/08/25, 08:25
-
Georg Ringer voted on patch set 4 CR +2 V +2 08/09/25, 08:06
-
Georg Ringer merged patch set 5 08/09/25, 08:06
RssWidget.php:103