Review main Merged

90238[BUGFIX] Properly parse Country property in CountrySelectViewHelper

Garvin Hicking CR +2 V +2 Easy +43 −1 updated 08/05/25, 09:28

Commit message

The implementation of #99911 missed to address that the
`<f:form.countrySelect>` ViewHelper needs to properly evaluate
the Country object, when referenced as a domain model property
instead of getting accessed via `value`.

This patch adds a test for this case and adapts retrieval
in the ViewHelper's `convertToPlainValue()` method.

Also, a drive-by typo is fixed.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Simon Praetorius +1
    • Jigal van Hemert +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Simon Praetorius +1
    • Jigal van Hemert +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1014

  1. Garvin Hicking uploaded patch set 1 08/04/25, 14:56

  2. Garvin Hicking uploaded patch set 2 08/04/25, 14:57

  3. Garvin Hicking uploaded patch set 3 08/04/25, 14:58

  4. core-ci voted on patch set 1 V -1 08/04/25, 15:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82760

  5. core-ci voted on patch set 2 V +1 08/04/25, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82761

  6. core-ci voted on patch set 3 V +1 08/04/25, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82762

  7. Jigal van Hemert commented on patch set 3 CR +1 V +1 08/04/25, 15:19

    Tested in v14 while preparing a T3DD talk.
  8. Oliver Klee updated the commit message in patch set 4 CR +1 V +1 08/04/25, 16:06

  9. core-ci voted on patch set 4 V +1 08/04/25, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82766

  10. Simon Praetorius voted on patch set 4 CR +1 V +1 08/04/25, 16:32

  11. Jigal van Hemert voted on patch set 4 CR +1 V +1 08/04/25, 16:38

  12. Oliver Klee voted on patch set 4 CR +1 V +1 08/04/25, 17:11

  13. Garvin Hicking voted on patch set 4 CR +2 V +2 08/05/25, 09:28

  14. Garvin Hicking merged patch set 5 08/05/25, 09:28