Review main Merged

90240[TASK] Require FormPersistenceManager to be injected

Simon Praetorius CR +2 V +2 Easy +9 −4 updated 08/05/25, 06:53

Commit message

In a previous refactoring of EXT:form internals, `makeInstance()` calls
for `FormPersistenceManagerInterface` have been reduced to just one.
Since the affected ViewHelper is now non-static, DI can be used there
as well. The default implementation `FormPersistenceManager` can
thus be non-public.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 78

  1. Simon Praetorius uploaded patch set 1 08/04/25, 15:46

  2. core-ci voted on patch set 1 V +1 08/04/25, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82765

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 08/04/25, 16:35

  4. Josua Vogel voted on patch set 1 CR +1 V +1 08/04/25, 16:42

  5. Garvin Hicking voted on patch set 1 CR +1 V +1 08/04/25, 17:01

  6. Oliver Klee voted on patch set 1 CR +1 V +1 08/04/25, 17:02

  7. Simon Praetorius voted on patch set 1 CR +2 V +2 08/05/25, 06:53

  8. Simon Praetorius merged patch set 2 08/05/25, 06:53