Review main Merged

90255[BUGFIX] Fix pixelated thumbnail FileInfo preview

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 11/26/25, 11:00

Commit message

Usage of `ProcessedFile::CONTEXT_IMAGEPREVIEW` is being phased
out in favor of `ProcessedFile::CONTEXT_IMAGECROPSCALEMASK`,
which does the "better" preview processing.

We have these two contexts:

'Image.Preview'
  => \TYPO3\CMS\Core\Resource\Processing\ImagePreviewTask::class
'Image.CropScaleMask'
  => \TYPO3\CMS\Core\Resource\Processing\ImageCropScaleMaskTask::class

The first uses a more basic image generation with lower quality,
while the other one uses full processing.

Remaining core usages of IMAGEPREVIEW:

* GridDataService with a 40x40 (ok for now)
* Default for ThumbnailViewHelper (might be adjusted?)
* FileController->flattenFileResultDataValue (only a stub?)

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Jasmina Ließmann +1
    • Oli Bartsch +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Jasmina Ließmann +1
    • Oli Bartsch +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 4

Files 1

Review log 811

  1. Garvin Hicking uploaded patch set 1 08/05/25, 06:48

  2. core-ci voted on patch set 1 V +1 08/05/25, 06:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82788

  3. Garvin Hicking rebased onto patch set 2 V +1 11/26/25, 08:22

  4. Garvin Hicking updated the commit message in patch set 3 11/26/25, 08:26

  5. core-ci voted on patch set 2 V +1 11/26/25, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91006

  6. core-ci voted on patch set 3 V +1 11/26/25, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91008

  7. Oli Bartsch voted on patch set 3 CR +1 V +1 11/26/25, 08:49

  8. Sven Liebert voted on patch set 3 CR +1 V +1 11/26/25, 10:06

  9. Jasmina Ließmann voted on patch set 3 CR +1 V +1 11/26/25, 10:46

  10. Garvin Hicking voted on patch set 3 CR +2 V +2 11/26/25, 10:52

  11. Garvin Hicking merged patch set 4 11/26/25, 11:00