Review main Merged

90257[TASK] Simplify <f:render> debugging implementation

Simon Praetorius CR +2 V +2 Hard +346 −117 updated 02/04/26, 14:50

Commit message

In an effort to reduce custom code in ViewHelper resolving, the
`<f:render>` debugging implementation of the admin panel is moved to
EXT:adminpanel. The activation logic, which depends on request
information, is now executed with each ViewHelper call (where this
information is available through proper APIs), but only if
EXT:adminpanel is installed.

This makes the conditional namespace merging in the
`ViewHelperResolver` obsolete and allows us to deprecate the custom
"debuggable" `RenderViewHelper` implementation in EXT:fluid.

Some backend functional tests need to be adjusted to provide
a proper backend request to (eventually) their Fluid template.
In addition, some outdated code comments are removed or
moved to the appropriate position.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Anja Leichsenring +1
    • Matthias Vogel +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Anja Leichsenring +1
    • Matthias Vogel +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 3044

Show 1319 earlier messages
  1. Simon Praetorius uploaded patch set 1 08/05/25, 09:38

  2. Simon Praetorius uploaded patch set 2 08/05/25, 09:44

  3. core-ci voted on patch set 2 V -1 08/05/25, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82797

  4. core-ci voted on patch set 1 V -1 08/05/25, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82796

  5. Simon Praetorius uploaded patch set 3 V -1 08/05/25, 10:07

  6. core-ci voted on patch set 3 V -1 08/05/25, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82798

  7. Simon Praetorius uploaded patch set 4 V -1 08/05/25, 14:40

  8. core-ci voted on patch set 4 V -1 08/05/25, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82813

  9. Simon Praetorius uploaded patch set 5 V -1 08/05/25, 14:55

  10. core-ci voted on patch set 5 V +1 08/05/25, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82814

  11. Simon Praetorius marked it ready for review 08/05/25, 15:05

  12. Benjamin Franzke commented on patch set 5 CR -1 08/05/25, 15:35

    RenderViewHelper.php:46

    I like that `ViewHelperResolver` removes REQUEST/user-based logic, but I dislike that this logic is now moved into `<f:render>` directly. When we are tackling this, we could – and should – avoid clobbering the EXT:fluid implementation (again) with adminpanel implementation details and instead ship this viewhelper as an overwrite for the viewhelper service in EXT:adminpanel. This is possible via a DI service overwrite in EXT:adminpanel. The adminpanel provided viewhelper then can make the runtime decision to evaluate `preview_showFluidDebug` and perform own rendering or use composition to dispatch to the original viewhelper, if `preview_showFluidDebug` is inactive.
  13. Simon Praetorius commented on patch set 5 08/05/25, 15:45

    RenderViewHelper.php:46 Reply

    Thanks for your feedback! I get your point, although I think that it's better (but not perfect) with this patch. How do you think about the additional `debug` argument that is already defined for the `<f:render>` ViewHelper even when the admin panel flag isn't active? Keep it or only define it if EXT:adminpanel is installed? I can see both variants: Keep it (to prevent exceptions if EXT:adminpanel is only installed as dev dependency) or remove it?
  14. Stefan Froemken commented on patch set 5 V -1 09/18/25, 21:43

    As the code was "only" transferred around in the core, the ViewHelper will still not respect the admPanel UserTSconfig. If admPanel.override.preview.showFluidDebug is disabled, it is still possible to render the debug output also with your patch. IMO we should first repair the broken part in core: https://review.typo3.org/c/Packages/TYPO3.CMS/+/90722 and then update your patch.
  15. Simon Praetorius commented on patch set 5 09/19/25, 15:39

    Reply

    Fine by me. This patch will most likely not be breaking, so I'll probably tackle this after 14.0 anyways.
  16. Simon Praetorius marked it work in progress 09/19/25, 15:39

  17. Simon Praetorius uploaded patch set 6 CR -1 V +1 01/12/26, 13:55

  18. core-ci voted on patch set 6 V +1 01/12/26, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93270

  19. Simon Praetorius uploaded patch set 7 V +1 01/12/26, 14:09

  1. core-ci voted on patch set 7 V +1 01/12/26, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93271

  2. Simon Praetorius uploaded patch set 8 V +1 01/12/26, 14:18

  3. Simon Praetorius marked it ready for review 01/12/26, 14:18

  4. Simon Praetorius commented on patch set 8 01/12/26, 14:22

    RenderViewHelper.php:46 Reply

    I've addressed this by moving the "debuggable" RenderViewHelper to EXT:adminpanel. The custom logic (= when should debug information be outputted) is now part of this ViewHelper. The regular ViewHelper namespace chain is used to override the default RenderViewHelper with the "debuggable" one. The default RenderViewHelper still defines the `debug` argument to prevent issues when EXT:adminpanel isn't available, as described above.
  5. core-ci voted on patch set 8 V +1 01/12/26, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93272

  6. Simon Schaufelberger uploaded patch set 9 V +1 01/12/26, 20:52

  7. Simon Schaufelberger commented on patch set 9 01/12/26, 20:52

    RenderViewHelper.php:70

    `$viewHelperVariableContainer->getView()` can also be null. shall we check that? otherwise we might introduce new phpstan errors at some point. I wonder why phpstan is not complaining already.
  8. core-ci voted on patch set 9 V +1 01/12/26, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93295

  9. Simon Praetorius uploaded patch set 10 V +1 01/13/26, 08:42

  10. Simon Praetorius commented on patch set 10 01/13/26, 08:44

    RenderViewHelper.php:70 Reply

    I don't want to make too many changes on the copied code in this patch, but in this case I copied the validation code from Fluid Standalone to the ViewHelper.
  11. core-ci voted on patch set 10 V -1 01/13/26, 08:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93321

  12. Simon Praetorius uploaded patch set 11 V -1 01/13/26, 10:18

  13. core-ci voted on patch set 11 V +1 01/13/26, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93328

  14. Anja Leichsenring voted on patch set 11 CR +1 V +1 01/15/26, 08:09

  15. Simon Praetorius uploaded patch set 12 CR +1 V +1 01/22/26, 15:42

  16. core-ci voted on patch set 12 V +1 01/22/26, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94057

  17. Simon Praetorius rebased onto patch set 13 V +1 01/22/26, 16:01

  18. core-ci voted on patch set 13 V +1 01/22/26, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94059

  19. Anja Leichsenring voted on patch set 13 CR +1 V +1 01/22/26, 16:24

  20. Matthias Vogel uploaded patch set 14 CR +1 V +1 02/04/26, 10:47

  21. Matthias Vogel voted on patch set 14 CR +1 V +1 02/04/26, 10:47

  22. core-ci voted on patch set 14 V +1 02/04/26, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95004

  23. Anja Leichsenring voted on patch set 14 CR +1 V +1 02/04/26, 14:23

  24. Simon Praetorius voted on patch set 14 CR +2 V +2 02/04/26, 14:50

  25. Simon Praetorius merged patch set 15 02/04/26, 14:50