90257[TASK] Simplify <f:render> debugging implementation
Commit message
Review
-
Code review CR +2 Done
- Simon Praetorius +2
- Anja Leichsenring +1
- Matthias Vogel +1
-
Verified V +2 Done
- Simon Praetorius +2
- Anja Leichsenring +1
- Matthias Vogel +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/adminpanel/Classes/ViewHelpers/Fluid/RenderViewHelper.php2new+159 −0
- typo3/sysext/adminpanel/Configuration/Fluid/Namespaces.phpnew+5 −0
- typo3/sysext/backend/Tests/Functional/Authentication/PasswordResetTest.php+4 −1
- typo3/sysext/backend/Tests/Functional/Controller/FormInlineAjaxControllerTest.php+5 −0
- typo3/sysext/backend/Tests/Functional/View/BackendViewFactoryTest.php+21 −6
- typo3/sysext/backend/Tests/Unit/Controller/FormInlineAjaxControllerTest.php+103 −84
- typo3/sysext/core/Documentation/Changelog/14.2/Deprecation-107208-FdebugrenderViewHelper.rstnew+36 −0
- typo3/sysext/fluid/Classes/Core/ViewHelper/ViewHelperResolver.php+0 −25
- typo3/sysext/fluid/Classes/ViewHelpers/Debug/RenderViewHelper.php+13 −1
Review log 3044
Show 1319 earlier messages
-
Simon Praetorius uploaded patch set 1 08/05/25, 09:38
-
Simon Praetorius uploaded patch set 2 08/05/25, 09:44
-
core-ci voted on patch set 2 V -1 08/05/25, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82797
-
core-ci voted on patch set 1 V -1 08/05/25, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82796
-
Simon Praetorius uploaded patch set 3
V -108/05/25, 10:07 -
core-ci voted on patch set 3 V -1 08/05/25, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82798
-
Simon Praetorius uploaded patch set 4
V -108/05/25, 14:40 -
core-ci voted on patch set 4 V -1 08/05/25, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82813
-
Simon Praetorius uploaded patch set 5
V -108/05/25, 14:55 -
core-ci voted on patch set 5 V +1 08/05/25, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82814
-
Simon Praetorius marked it ready for review 08/05/25, 15:05
-
Benjamin Franzke commented on patch set 5 CR -1 08/05/25, 15:35
-
Simon Praetorius commented on patch set 5 08/05/25, 15:45
RenderViewHelper.php:46ReplyThanks for your feedback! I get your point, although I think that it's better (but not perfect) with this patch. How do you think about the additional `debug` argument that is already defined for the `<f:render>` ViewHelper even when the admin panel flag isn't active? Keep it or only define it if EXT:adminpanel is installed? I can see both variants: Keep it (to prevent exceptions if EXT:adminpanel is only installed as dev dependency) or remove it? -
Stefan Froemken commented on patch set 5 V -1 09/18/25, 21:43
As the code was "only" transferred around in the core, the ViewHelper will still not respect the admPanel UserTSconfig. If admPanel.override.preview.showFluidDebug is disabled, it is still possible to render the debug output also with your patch. IMO we should first repair the broken part in core: https://review.typo3.org/c/Packages/TYPO3.CMS/+/90722 and then update your patch. -
Simon Praetorius commented on patch set 5 09/19/25, 15:39
Reply
Fine by me. This patch will most likely not be breaking, so I'll probably tackle this after 14.0 anyways. -
Simon Praetorius marked it work in progress 09/19/25, 15:39
-
Simon Praetorius uploaded patch set 6
CR -1V +101/12/26, 13:55 -
core-ci voted on patch set 6 V +1 01/12/26, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93270
-
Simon Praetorius uploaded patch set 7
V +101/12/26, 14:09
-
core-ci voted on patch set 7 V +1 01/12/26, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93271
-
Simon Praetorius uploaded patch set 8
V +101/12/26, 14:18 -
Simon Praetorius marked it ready for review 01/12/26, 14:18
-
Simon Praetorius commented on patch set 8 01/12/26, 14:22
RenderViewHelper.php:46ReplyI've addressed this by moving the "debuggable" RenderViewHelper to EXT:adminpanel. The custom logic (= when should debug information be outputted) is now part of this ViewHelper. The regular ViewHelper namespace chain is used to override the default RenderViewHelper with the "debuggable" one. The default RenderViewHelper still defines the `debug` argument to prevent issues when EXT:adminpanel isn't available, as described above. -
core-ci voted on patch set 8 V +1 01/12/26, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93272
-
Simon Schaufelberger uploaded patch set 9
V +101/12/26, 20:52 -
Simon Schaufelberger commented on patch set 9 01/12/26, 20:52
RenderViewHelper.php:70`$viewHelperVariableContainer->getView()` can also be null. shall we check that? otherwise we might introduce new phpstan errors at some point. I wonder why phpstan is not complaining already. -
core-ci voted on patch set 9 V +1 01/12/26, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93295
-
Simon Praetorius uploaded patch set 10
V +101/13/26, 08:42 -
Simon Praetorius commented on patch set 10 01/13/26, 08:44
RenderViewHelper.php:70ReplyI don't want to make too many changes on the copied code in this patch, but in this case I copied the validation code from Fluid Standalone to the ViewHelper. -
core-ci voted on patch set 10 V -1 01/13/26, 08:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93321
-
Simon Praetorius uploaded patch set 11
V -101/13/26, 10:18 -
core-ci voted on patch set 11 V +1 01/13/26, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93328
-
Anja Leichsenring voted on patch set 11 CR +1 V +1 01/15/26, 08:09
-
Simon Praetorius uploaded patch set 12
CR +1V +101/22/26, 15:42 -
core-ci voted on patch set 12 V +1 01/22/26, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94057
-
Simon Praetorius rebased onto patch set 13
V +101/22/26, 16:01 -
core-ci voted on patch set 13 V +1 01/22/26, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94059
-
Anja Leichsenring voted on patch set 13 CR +1 V +1 01/22/26, 16:24
-
Matthias Vogel uploaded patch set 14
CR +1V +102/04/26, 10:47 -
Matthias Vogel voted on patch set 14 CR +1 V +1 02/04/26, 10:47
-
core-ci voted on patch set 14 V +1 02/04/26, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95004
-
Anja Leichsenring voted on patch set 14 CR +1 V +1 02/04/26, 14:23
-
Simon Praetorius voted on patch set 14 CR +2 V +2 02/04/26, 14:50
-
Simon Praetorius merged patch set 15 02/04/26, 14:50
RenderViewHelper.php:46