Review 13.4 Merged

90260[TASK] Add return type hints to ViewHelper classes

Simon Praetorius CR +2 V +2 Easy +12 −27 updated 08/05/25, 16:37

Commit message

In preparation for stricter ViewHelper types from the base classes,
all TYPO3 ViewHelpers need return type hints for `render()` and
`initializeArguments()`. Some drive-by types are added as well.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
  • Verified V +2 Done
    • Simon Praetorius +2
    • core-ci +1 CI

Issues 1

Files 9

Review log 46

  1. Simon Praetorius commented on patch set 1 08/05/25, 16:10

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 08/05/25, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82815

  3. Simon Praetorius updated the commit message in patch set 2 V +1 08/05/25, 16:17

  4. core-ci voted on patch set 2 V +1 08/05/25, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82816

  5. Simon Praetorius voted on patch set 2 CR +2 V +2 08/05/25, 16:37

  6. Simon Praetorius merged patch set 3 08/05/25, 16:37