90268[!!!][TASK] Drop support for Extbase Annotations
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Torben Hansen +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- Torben Hansen +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 62
- Build/phpstan/phpstan-baseline.neon+2 −2
- Build/phpstan/phpstan.neon+0 −2
- Build/Scripts/phpIntegrityChecks/AnnotationChecker.php+0 −12
- typo3/sysext/beuser/Classes/Domain/Model/BackendUser.php+2 −4
- typo3/sysext/beuser/Classes/Domain/Model/BackendUserGroup.php+2 −2
- typo3/sysext/beuser/Classes/Domain/Model/FileMount.php+2 −3
- typo3/sysext/core/Classes/Core/Bootstrap.php+1 −9
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107229-RemovedSupportOfAnnotationsInExtbase.rst6new+111 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield/Classes/Domain/Model/Hotel.php+2 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield/Classes/Domain/Model/Offer.php+2 −2
- typo3/sysext/core/composer.json+0 −1
- typo3/sysext/extbase/Classes/Attribute/ORM/Cascade.phprenamed+2 −8
- typo3/sysext/extbase/Classes/Attribute/ORM/Lazy.phprenamed+1 −5
- typo3/sysext/extbase/Classes/Attribute/ORM/Transient.phprenamed+1 −5
- typo3/sysext/extbase/Classes/Attribute/FileUpload.php7renamed+1 −9
- typo3/sysext/extbase/Classes/Attribute/IgnoreValidation.phprenamed+1 −5
- typo3/sysext/extbase/Classes/Attribute/Validate.phprenamed+1 −10
- typo3/sysext/extbase/Classes/Domain/Model/Category.php+3 −7
- typo3/sysext/extbase/Classes/Mvc/Dispatcher.php+3 −3
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php2+3 −2
Show 42 more files
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php6+15 −97
- typo3/sysext/extbase/Migrations/Code/ClassAliasMap.php6new+12 −0
- typo3/sysext/extbase/Migrations/Code/LegacyClassesForIde.phpnew+50 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/action_controller_argument_test/Classes/Controller/ArgumentTestController.php+10 −7
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/action_controller_test/Classes/Controller/TestController.php+10 −7
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/BlogController.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/BlogPostEditingController.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Blog.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Category.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Comment.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Post.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/RestrictedComment.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/TtContent.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/file_upload/Classes/Domain/Model/Dto/FileUploadObjectStorageUploadedFile.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/file_upload/Classes/Domain/Model/FileReferencePropertyMultiple.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/file_upload/Classes/Domain/Model/FileReferencePropertySingle.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/file_upload/Classes/Domain/Model/FileUploadMultipleProperties.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Classes/Domain/Model/Main.php+4 −6
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/Domain/Model/AliasedModel.php8new+43 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/Domain/Model/AnotherModel.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/Domain/Model/Model.php+6 −5
- typo3/sysext/extbase/Tests/Functional/Validation/ValidatorResolverTest.php+67 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchema/MethodParameterTest.php+3 −29
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchema/PropertyTest.php+2 −96
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithAllTypesOfProperties.php+2 −18
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithIgnoreValidationAttribute.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithIgnoreValidationDoctrineAnnotation.phpdeleted+0 −35
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithLazyAttribute.phprenamed+2 −10
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyController.php+3 −11
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyControllerWithIgnoreValidationAttributes.phprenamed+3 −3
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyControllerWithIgnoreValidationDoctrineAnnotation.phpdeleted+0 −44
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyControllerWithValidateAnnotationWithoutParam.phpdeleted+0 −33
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyControllerWithValidateAnnotationWithoutParamTypeHint.phpdeleted+0 −32
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyControllerWithValidateAttributeWithoutParam.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyControllerWithValidateAttributeWithoutParamTypeHint.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyModel.php+2 −15
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+0 −24
- typo3/sysext/extbase/composer.json+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+30 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyAnnotationMatcher.php+5 −0
- composer.json+3 −1
- composer.lock+1 −77
Review log 7496
Show 5271 earlier messages
-
Elias Häußler uploaded patch set 1 08/07/25, 19:23
-
Elias Häußler uploaded patch set 2 08/07/25, 19:37
-
core-ci voted on patch set 1 V -1 08/07/25, 19:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82882
-
core-ci voted on patch set 2 V -1 08/07/25, 20:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82887
-
Elias Häußler uploaded patch set 3
V -108/07/25, 20:43 -
core-ci voted on patch set 3 V -1 08/07/25, 21:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82928
-
Elias Häußler uploaded patch set 4
V -108/07/25, 21:29 -
core-ci voted on patch set 4 V -1 08/07/25, 21:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82941
-
Elias Häußler uploaded patch set 5
V -108/07/25, 22:02 -
core-ci voted on patch set 5 V +1 08/07/25, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82958
-
Elias Häußler uploaded patch set 6
V +108/08/25, 11:58 -
core-ci voted on patch set 6 V +1 08/08/25, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83012
-
Elias Häußler uploaded patch set 7
V +108/08/25, 12:06 -
Elias Häußler marked it ready for review 08/08/25, 12:08
-
core-ci voted on patch set 7 V +1 08/08/25, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83013
-
Simon Schaufelberger voted on patch set 7 CR +1 08/08/25, 12:20
-
Markus Klein commented on patch set 7 08/08/25, 13:52
-
René Pflamm voted on patch set 7 CR +1 08/08/25, 14:28
-
Elias Häußler commented on patch set 7 08/08/25, 14:47
FileUpload.php:31ReplyIn this patch, there is now effective replacement. However, I created https://review.typo3.org/c/Packages/TYPO3.CMS/+/90296 which aims to fill this gap by introducing required properties for attributes (which replace the currently used array as parameter in the attribute constructors). -
Stefan Bürk commented on patch set 7 08/11/25, 00:04
@elias@haeussler.dev We usually add the used (composer) commands to the commit message as a `Used command(s)` block like for example here https://review.typo3.org/c/Packages/TYPO3.CMS/+/88596 Example: ``` BIN_COMPOSER="$( which composer )" \ && ${BIN_COMPOSER} require \ -d typo3/sysext/core --no-update --no-install \ 'doctrine/dbal':'>= 4.3.1 < 4.4.0' \ && ${BIN_COMPOSER} require \ -d typo3/sysext/install --no-update --no-install \ 'doctrine/dbal':'>= 4.3.1 < 4.4.0' \ && ${BIN_COMPOSER} require \ -d typo3/sysext/redirects --no-update --no-install \ 'doctrine/dbal':'>= 4.3.1 < 4.4.0' \ && ${BIN_COMPOSER} require -w \ 'doctrine/dbal':'>= 4.3.1 < 4.4.0' \ && Build/Scripts/runTests.sh -s phpstanGenerateBaseline ```FileUpload.php:31ReplyNot tested, but I guess that we could use the required attribute as replacement. See: https://github.com/symfony/symfony/issues/48909 ``` - /** - @required - / + #[\Symfony\Contracts\Service\Attribute\Required] ``` However, not sure if that works for customphp attributes anyway (or if that worked before). -
Stefan Bürk commented on patch set 7 08/11/25, 00:07
And as an additional `@todo`, the `Build/Scripts/phpIntegrityChecks/AnnotationChecker.php` should be checked for annoation not valid anymore to mitigate adding non-working annoations in the future. -
Markus Klein commented on patch set 7 08/11/25, 07:04
FileUpload.php:31ReplySo we should wait with this one until the replacements are in place. I'm not a big fan of removing stuff because the replacement is there soon™. We had that in the past. -
Elias Häußler uploaded patch set 8
CR +1V +108/12/25, 13:33 -
Elias Häußler commented on patch set 8 08/12/25, 13:34
Reply
DoneReply
DoneFileUpload.php:31ReplyThe `@Required` annotation was previously parsed by Doctrine to indicate that a specific property was required (see https://github.com/doctrine/annotations/blob/v1.8.0/lib/Doctrine/Common/Annotations/DocParser.php#L545 for the implementation). Hence, I'd say that replacing it with a Symfony attribute does not have an effect on attribute parsing/validation. The "problem" with the follow-up patch I linked before is that it does not work in combination with Doctrine attributes (better said: It *does* work, but would be highly breaking). Ideally, we'd put both changes into one, but I fear that this would be too much changes in one patch. -
core-ci voted on patch set 8 V +1 08/12/25, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83204
-
Stefan Froemken commented on patch set 8 CR -1 08/13/25, 07:58
Doctrine Annotations are "Attribute", "Enum", "Required" and "Target" and I have never seen these real Doctrine annotations in any extbase extensionBreaking-107229-RemovedSupportOfDoctrineAnnotationsInExtbase.rst:14I don't understand that. Which doctrine annotations? There are no Doctrine Annotations in Extbase.Breaking-107229-RemovedSupportOfDoctrineAnnotationsInExtbase.rst:42In your example below you use "Validate". That is a PHP Attribute, but that's not a "native" PHP attribute. This is a specific Extbase class which is marked as PHP attribute.Breaking-107229-RemovedSupportOfDoctrineAnnotationsInExtbase.rst:53As you see, it's an extbase annotation. The desired class is part of the extbase framework. The only relation to doctrine is the folder name "ORM". In these classes nothing relates to doctrine.Breaking-107229-RemovedSupportOfDoctrineAnnotationsInExtbase.rst:72Correct: From "extbase" and not "Doctrine" -
Alexander Schnitzler commented on patch set 8 08/14/25, 10:46
Breaking-107229-RemovedSupportOfDoctrineAnnotationsInExtbase.rst:14ReplyIt's about removing support for doctrine annotations in favor of attributes and get rid of the doctrine/annotations package. Currently both is still possible. To use the class as attribute and as annotation i.e. inside a phpdoc comment. The latter will no longer be possible with this change. It's not about annotations of the doctrine/anotations package, it's about marking functionality with an annoation instead of an attribute.Breaking-107229-RemovedSupportOfDoctrineAnnotationsInExtbase.rst:42Reply@Annotation is what makes this class and the others an annotation.Breaking-107229-RemovedSupportOfDoctrineAnnotationsInExtbase.rst:53ReplyIt's not about doctrine/orm, it's about doctrine/annotations. I guess it's best to check the ClassSchema class and see that we currently check for doctrine annotations and attributes.Breaking-107229-RemovedSupportOfDoctrineAnnotationsInExtbase.rst:72ReplyThe classes, which have been created as annotations and which are currently both annotations and attributes at the same time are moved into the attributes namespace. -
Elias Häußler commented on patch set 8 08/14/25, 14:04
Reply
Technically, that's correct, yes. I was referring to Doctrine annotations as the annotations which are used in Extbase and parsed by Doctrine's `AnnotationReader`, hence the naming. But I'm of course open for a better naming here, especially if the one I used leads to confusion. What is removed by this patch is the possibility to have annotations in place (it actually doesn't matter if it's Extbase annotations or third-party annotations). PHP attributes should be used instead, and support for parsing annotations (by Doctrine's `AnnotationReader`) is dropped.Breaking-107229-RemovedSupportOfDoctrineAnnotationsInExtbase.rst:14ReplyExactly what @git@alexanderschnitzler.de said (see my comment at patch level as well).Breaking-107229-RemovedSupportOfDoctrineAnnotationsInExtbase.rst:42ReplyDo you have suggestions for a better explanation? Or is your comment just about dropping the "native" part?Breaking-107229-RemovedSupportOfDoctrineAnnotationsInExtbase.rst:53ReplyCorrect, thanks @git@alexanderschnitzler.de. Please check my comment at patch level regarding the naming of "Doctrine annotations".Breaking-107229-RemovedSupportOfDoctrineAnnotationsInExtbase.rst:72ReplyI don't understand your comment, @froemken@gmail.com. The FQCN of the attribute classes (which were also annotations before) was moved from `TYPO3\CMS\Extbase\Annotation` to `TYPO3\CMS\Extbase\Attribute`. There's no Doctrine involved here. -
Elias Häußler uploaded patch set 9
CR -1V +108/14/25, 14:41 -
core-ci voted on patch set 9 V +1 08/14/25, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83394
-
Benni Mack uploaded patch set 10
V +108/14/25, 15:54 -
core-ci voted on patch set 10 V +1 08/14/25, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83403
-
Stefan Froemken commented on patch set 10 08/14/25, 18:48
Thank you for clarifying my remarks in new patch.Backend.php:311Should be "the". You add a very specific attribute here. -
Stefan Froemken commented on patch set 11
V +108/14/25, 19:21Published edit on patch set 10. -
Stefan Froemken commented on patch set 11 CR +1 08/14/25, 19:21
Backend.php:311ReplyDone -
core-ci voted on patch set 11 V +1 08/14/25, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83406
-
Simon Schaufelberger commented on patch set 11 08/17/25, 06:35
must be /** in order to be a proper doctype -
Elias Häußler uploaded patch set 12
CR +1V +108/17/25, 14:24 -
Elias Häußler commented on patch set 12 08/17/25, 14:25
Reply
Done -
Elias Häußler commented on patch set 12 08/17/25, 14:26
Breaking-107229-RemovedSupportOfDoctrineAnnotationsInExtbase.rst:14ReplyDoneBreaking-107229-RemovedSupportOfDoctrineAnnotationsInExtbase.rst:42ReplyDoneBreaking-107229-RemovedSupportOfDoctrineAnnotationsInExtbase.rst:53ReplyDoneBreaking-107229-RemovedSupportOfDoctrineAnnotationsInExtbase.rst:72ReplyDone -
core-ci voted on patch set 12 V +1 08/17/25, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83533
-
Sascha Nowak voted on patch set 12 CR +1 08/18/25, 14:58
-
Elias Häußler wrote 08/21/25, 06:55
Topic set to extbase -
Elias Häußler uploaded patch set 13
CR +1V +108/25/25, 12:58 -
core-ci voted on patch set 13 V +1 08/25/25, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83846
-
Benni Mack uploaded patch set 14
V +109/01/25, 15:22 -
core-ci voted on patch set 14 V +1 09/01/25, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84175
-
Garvin Hicking uploaded patch set 15
V +109/24/25, 21:59 -
Garvin Hicking commented on patch set 15 CR +1 09/24/25, 22:01
Generally this works and we should try to have this in v14 IMO. Some minor RST comments and I believe the class-aliasing doesn't fully work for the PropertyMapper?!Breaking-107229-RemovedSupportOfAnnotationsInExtbase.rst:93How about adding a note like: ``` .. hint:: Doing a "search and replace" can ideally be done programmatically with something like a Rector rule or similar. ``` Maybe @simonschaufi+typo3@gmail.com would chime in if it's likely that TYPO3 Rector will receive this for a v14 release and we can adjust the changelog later to refer to that rule...?Breaking-107229-RemovedSupportOfAnnotationsInExtbase.rst:103How about adding `TYPO3\CMS\Extbase\Annotation` to `typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php` so that the Extension scanner will alert at both this migration and possible need to replace an annotation with an attribute?FileUpload.php:31ReplySince this is the only place of the core that '@Required' is used, how about modifying the constructor to check for a non-empty 'validation' array and throwing a specific exception? The follow-up patch is IMO indeed too complex to merge it with this one. And I think it should not block/stalemate this current approach.ClassAliasMap.php:5This does not seem to work in practice for me. A model like this: ``` <?php declare(strict_types=1); namespace Garvinhicking\ExtbaseUpload\Domain\Model; use TYPO3\CMS\Extbase\Annotation\FileUpload; use TYPO3\CMS\Extbase\Domain\Model\FileReference; use TYPO3\CMS\Extbase\DomainObject\AbstractEntity; class Singlefile extends AbstractEntity { #[FileUpload([ 'validation' => [ 'maxFiles' => 1, ], 'uploadFolder' => '1:/user_upload/', ])] protected ?FileReference $fileUnrestrictedSingle = null; public function getFileUnrestrictedSingle(): ?FileReference { return $this->fileUnrestrictedSingle; } public function setFileUnrestrictedSingle(?FileReference $fileUnrestrictedSingle): void { $this->fileUnrestrictedSingle = $fileUnrestrictedSingle; } } ``` upon persisting in Extbase throws an: ``` (1/2) #1297759968 TYPO3\CMS\Extbase\Property\Exception Exception while property mapping at property path "fileUnrestrictedSingle": The source is not of type string, array, float, integer or boolean, but of type "object" in /var/www/html/typo3-core/typo3/sysext/extbase/Classes/Property/PropertyMapper.php line 66 ``` -
core-ci voted on patch set 15 V +1 09/24/25, 22:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85469
-
Garvin Hicking uploaded patch set 16
CR +1V +109/25/25, 08:33 -
core-ci voted on patch set 16 V +1 09/25/25, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85491
-
Garvin Hicking commented on patch set 16 09/25/25, 17:03
ClassAliasMap.php:5ReplyI think this was missing to to the composer.json entries, Stefan Bürk hinted me at that. It works now with core classes, but for me not for locally fetched extensions. Might be specific to my monorepo-composer setup, so resolving this. -
Garvin Hicking uploaded patch set 17
V +109/25/25, 18:31 -
Garvin Hicking commented on patch set 17 CR -1 09/25/25, 18:34
ClassAliasMap.php:5ReplyI created a test that sadly seems to prove that the aliased namespace does in fact not seem to work properly. Changing line 20 `typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/Domain/Model/AliasedModel.php` from `use TYPO3\CMS\Extbase\Annotation` to `use TYPO3\CMS\Extbase\Attribute` makes the test pass. Sadly I don't know enough of the gory details how aliasing should/could work. If it doesn't work I guess we would first have to deprecate the usage before we can remove it to have the 2-version LTS compatibility in place. -
core-ci voted on patch set 17 V -1 09/25/25, 18:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85544
-
Alexander Schnitzler commented on patch set 17 09/25/25, 19:15
AliasedModel.php:20This is the wrong namespace. `Annotation` no longer exists. It's `Attribute`.AliasedModel.php:39Aliasing isn't a TYPO3 feature, it's plain PHP. Your IDE will show that the classes used here don't exist due to the wrong namespace. -
Garvin Hicking commented on patch set 17 09/25/25, 19:30
AliasedModel.php:20ReplyBut that's the idea of the Alias, isn't it? To allow using the "old" namespace as long as it's aliased? I thought this is a feature of the Class Loader, because composer also does things there. Also: This works when I insert the statement into a TYPO3 core controller (like in EXT:form's controller in the `renderAction`). I don't understand why it works there and not inside a testing-framework or custom composer package. -
Alexander Schnitzler commented on patch set 17 09/25/25, 20:00
AliasedModel.php:20ReplyI am not sure how you define an alias here. I thought you mean the `Annotation as Extbase` or `Attribute as Extbase` alias. I don't know of any class loader specific aliasing. If that exists, I am not familiar with it and someone else needs to step in here. My unnderstanding of this patch is that Annotations classes are removed (breaking) and that people MUST switch from Annotation (classes) to Attribute (classes) as explained in the commit message. Maybe I am wrong here. Don't know atm. -
Andreas Kienast commented on patch set 17 09/26/25, 04:37
ClassAliasMap.php:5ReplyJust to rule out the obvious one: did you run `composer dump-autoload`?AliasedModel.php:20Reply> If that exists, I am not familiar with it and someone else needs to step in here. Please see the changes in EXT:extbase/composer.json and EXT:extbase/Migrations/Code/ClassAliasMap.php – this feature exists since TYPO3 v6. -
Alexander Schnitzler commented on patch set 17 09/26/25, 05:48
ClassAliasMap.php:5ReplyI just did and it actually doesn't work despite having those entries in autoload_classaliasmap.php: `'typo3\\cms\\extbase\\annotation\\orm\\cascade' => 'TYPO3\\CMS\\Extbase\\Attribute\\ORM\\Cascade'` Can't rule out that it's my setup as well but I am quite sure it's not. I ran dumpautoload inside the core repo and I am running the functional tests from within there as well. It should reflect the behaviour of the CI job.AliasedModel.php:20ReplyHehe, I am sorry. I slightly remember this now from the t3lib_div days but I was completely unaware this still exists. I just had a brief moment to check this patch and jumped to conclusions too quickly because I thought it's about the native aliasing feature of PHP.AliasedModel.php:39ReplyDone -
Andreas Kienast commented on patch set 17 09/26/25, 07:39
ClassSchema.php:144These classes reference the new `\Attribute` namespace, which in turns leads to the situation that the old `\Annotation` namespace, as used in the `AliasedModel` test case, is ignored. -
Garvin Hicking commented on patch set 17 CR 0 09/26/25, 08:48
ClassSchema.php:144ReplyThanks for diving into this, I understand. So basically this means we cannot keep the old alias in place easily. If I see this correctly, we should only deprecate the old namespace (if I see correctly, this has not been done yet), keep the old namespace for now, and then do the breaking change in v15? This patch could still replace annotations with attributes, but in the old namespace, right?ClassAliasMap.php:5ReplySee Andis explanation below, resolving this thread.AliasedModel.php:20ReplyThanks for jumping to help, it was (is) all a bit fuzzy to me. Resolving this one here. :) -
Elias Häußler commented on patch set 17 09/26/25, 09:22
ClassSchema.php:144ReplyThank you very much for these insights! This is indeed a problem.. Could it be solved like this? ``` \TYPO3\CMS\Extbase\Attribute\Validate::class, \TYPO3\CMS\Extbase\Annotation\Validate::class => $validateAttributes[] = $attribute, ``` We could then remove the second match (the one with `Annotation` namespace) with v15. -
Elias Häußler uploaded patch set 18
V -109/26/25, 09:38 -
Elias Häußler commented on patch set 18 09/26/25, 09:39
ClassSchema.php:144ReplyThe failing test went green locally with this change, so I pushed it as new patchset. Please have a second look. 😊 -
core-ci voted on patch set 18 V +1 09/26/25, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85587
-
Andreas Kienast commented on patch set 18 CR -1 09/26/25, 11:13
ClassSchema.php:144ReplyI'll push another support file for IDEs. -
Andreas Kienast uploaded patch set 19
CR -1V +109/26/25, 11:15 -
core-ci voted on patch set 19 V +1 09/26/25, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85592
-
Garvin Hicking commented on patch set 19 CR +1 V +1 09/26/25, 23:29
ClassSchema.php:144ReplyDone
-
Oliver Klee voted on patch set 19 V +1 09/27/25, 13:54
-
Simon Schaufelberger commented on patch set 19 09/30/25, 08:36
Breaking-107229-RemovedSupportOfAnnotationsInExtbase.rst:93Replysince my budget got approved, I'll try on create a rule for that when merged. -
Garvin Hicking commented on patch set 19 09/30/25, 11:00
Breaking-107229-RemovedSupportOfAnnotationsInExtbase.rst:93ReplyCool. I'll resolve this for now, I think we should then add this hint later, and then we could directly link to the rule. -
Garvin Hicking commented on patch set 19 09/30/25, 11:05
FileUpload.php:31Reply... actually, the `FileUploadConfiguration` class that consumes this attribute already has this check in place: ``` if (!isset($configuration['validation']) || $configuration['validation'] === []) { throw new \RuntimeException('Extbase file upload must at least define one validation rule.', 1711947120); } ``` so this 'Required' use wouldn't fall flat, and is still enforced on code-level. I would like to resolve this, please re-open in case of complaints. 😊 -
Elias Häußler uploaded patch set 20
CR +1V +109/30/25, 17:55 -
Elias Häußler commented on patch set 20 09/30/25, 17:56
Breaking-107229-RemovedSupportOfAnnotationsInExtbase.rst:103ReplyDone -
Garvin Hicking commented on patch set 20 CR +1 V +1 09/30/25, 17:58
Breaking-107229-RemovedSupportOfAnnotationsInExtbase.rst:103ReplyThanks! :) -
core-ci voted on patch set 20 V +1 09/30/25, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85753
-
Elias Häußler uploaded patch set 21
CR +1V +109/30/25, 18:16 -
core-ci voted on patch set 21 V +1 09/30/25, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85754
-
Elias Häußler uploaded patch set 22
V +109/30/25, 18:27 -
core-ci voted on patch set 22 V +1 09/30/25, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85755
-
Oliver Klee voted on patch set 22 V +1 09/30/25, 18:43
-
Garvin Hicking voted on patch set 22 CR +1 V +1 09/30/25, 18:45
-
Simon Schaufelberger voted on patch set 22 CR +1 V +1 09/30/25, 18:48
-
René Pflamm wrote 09/30/25, 19:07
Removed reviewer René Pflamm. -
Torben Hansen voted on patch set 22 CR +1 V +1 10/01/25, 16:08
-
Garvin Hicking voted on patch set 22 CR +2 V +2 10/01/25, 16:53
-
Garvin Hicking merged patch set 23 10/01/25, 16:53
-
Lina Wolf commented on patch set 23 10/05/25, 06:25
What about using the `@var` annotation instead of types properties? has that also been removed? -
Garvin Hicking commented on patch set 23 10/05/25, 06:51
Reply
No, these are php-doc annotations, see changelog: "Note that usage of PHPDoc annotations like :php:`@param`, :php:`@return` and others are unaffected by this change, as they do not require specific Doctrine annotation parsing. Especially explicit parameter type annotations like :php:`@param ObjectStorage<MyModel>` are still fully supported." -
Lina Wolf commented on patch set 23 10/05/25, 11:38
Reply
I think, that the title of the changelog entry sounds quite misleading. Expecially since we have used the words annotation for these constructs no matter which syntax they used until now in the docs. -
Garvin Hicking commented on patch set 23 10/05/25, 13:19
Reply
Hm, I don't see it like this. we specifically mention extbase annotations and do differ them to php-doc annotations. php-doc annotations are just comments! extbase annotations are actively namespaced. -
Elias Häußler commented on patch set 23 10/06/25, 06:59
Reply
@112@linawolf.de @garvin@hick.ing I made a follow-up for the changelog file, please have a look at https://review.typo3.org/c/Packages/TYPO3.CMS/+/90907. -
Garvin Hicking commented on patch set 23 10/17/25, 08:23
Reply
Done
FileUpload.php:31