90271[BUGFIX] Treat page translation as page edit permission
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +2
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +2
- core-ci +1 CI
Issues 1
Files 1
Review log 1317
-
Lisa Kreitz uploaded patch set 1 08/07/25, 19:56
-
core-ci voted on patch set 1 V +1 08/07/25, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82903
-
Benni Mack updated the commit message in patch set 2
V +108/07/25, 21:34 -
core-ci voted on patch set 2 V +1 08/07/25, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82943
-
Oli Bartsch commented on patch set 2 08/09/25, 07:48
-
Christian Kuhn commented on patch set 2 08/13/25, 19:58
DataHandler.php:7272Replyi'll try to review & think in detail tomorrow. i'd try to not have a new permission for this, though, to not make this system more complex than it is already. -
Lisa Kreitz commented on patch set 2 08/14/25, 06:59
DataHandler.php:7272ReplyI totally agree with both of you. I also wanted to avoid introducing a new permission. And i'm also not quite sure if this is the right approach, but would be happy to discuss over it. -
Christian Kuhn commented on patch set 2 08/14/25, 10:54
DataHandler.php:7272ReplyI tend to agree to Lisas solution: PAGE_NEW is odd, and the easiest solution is to treat 'creating page translations' as PAGE_EDIT. -
Christian Kuhn uploaded patch set 3
V +108/14/25, 11:07 -
Christian Kuhn commented on patch set 2 08/14/25, 11:07
DataHandler.php:7272ReplyI added that decision as comment to hasPermissionToInsert(). -
Christian Kuhn uploaded patch set 4 08/14/25, 11:10
-
core-ci voted on patch set 3 V +1 08/14/25, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83382
-
core-ci voted on patch set 4 V +1 08/14/25, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83383
-
Christian Kuhn voted on patch set 4 CR +1 V +1 08/14/25, 11:19
-
Stefan Bürk voted on patch set 4 CR +2 V +2 08/14/25, 11:26
-
Christian Kuhn voted on patch set 4 CR +2 V +2 08/14/25, 11:44
-
Christian Kuhn merged patch set 5 08/14/25, 11:44
DataHandler.php:7272