Review main Merged

90274[FEATURE] Add language dropdown in record history

Friedemann Altrock CR +2 V +2 Normal +163 −0 updated 03/30/26, 14:42

Commit message

The record history only shows the changelog for a specific record UID.
This means translations and their changes are impossible to reach from
the page tree, though they can already be accessed from the list module
or the page module language view.

This adds a dropdown of the available translated languages to the record
history view's button bar.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 3851

Show 1826 earlier messages
  1. Friedemann Altrock uploaded patch set 1 08/07/25, 20:24

  2. core-ci voted on patch set 1 V -1 08/07/25, 20:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82918

  3. Friedemann Altrock uploaded patch set 2 V -1 08/07/25, 21:09

  4. Friedemann Altrock uploaded patch set 3 08/07/25, 21:14

  5. core-ci voted on patch set 2 V -1 08/07/25, 21:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82936

  6. core-ci voted on patch set 3 V +1 08/07/25, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82937

  7. Andreas Wolf commented on patch set 3 08/07/25, 21:51

    ElementHistoryController.php:247

    Should this probably be injected via DI?
  8. Andreas Wolf voted on patch set 3 CR +1 08/07/25, 21:51

  9. Garvin Hicking commented on patch set 3 08/07/25, 21:51

    We need a feature RST for this I'm afraid :)

    ElementHistoryController.php:225

    I would probably remove these type hints due to redundancy?

    ElementHistoryController.php:247

    I think we can also draw this into __construct for DI?

    ElementHistoryController.php:264

    (Just as a side note, I believe recent PHPStorm finally gets this right without this annotation :) )
  10. Friedemann Altrock uploaded patch set 4 CR +1 V +1 08/07/25, 22:25

  11. Friedemann Altrock commented on patch set 3 08/07/25, 22:26

    Reply

    Hah, yes, added in the next patchset.

    ElementHistoryController.php:225 Reply

    Done

    ElementHistoryController.php:247 Reply

    Done

    ElementHistoryController.php:247 Reply

    Done

    ElementHistoryController.php:264 Reply

    Indeed.
  12. core-ci voted on patch set 4 V -1 08/07/25, 22:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82964

  13. Friedemann Altrock uploaded patch set 5 V -1 08/08/25, 06:39

  14. core-ci voted on patch set 5 V +1 08/08/25, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82982

  15. Sebastian Michaelsen commented on patch set 5 CR +1 V +1 08/08/25, 07:15

    works great
  16. Sebastian Michaelsen commented on patch set 5 CR 0 V -1 08/08/25, 07:18

    When editing a page in workspaces, then the dropdown loads language versions of LIVE and the workspaces, so there are duplicate language options and LIVE and WS records mixed up.
  17. Friedemann Altrock uploaded patch set 6 V +1 08/08/25, 07:29

  18. Friedemann Altrock commented on patch set 5 08/08/25, 07:29

    Reply

    Done, added the workspace restriction as you suggested.
  19. Sebastian Michaelsen voted on patch set 6 CR +1 V +1 08/08/25, 07:30

  20. core-ci voted on patch set 6 V +1 08/08/25, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82985

  21. Benni Mack uploaded patch set 7 CR +1 V +1 08/09/25, 09:40

  22. core-ci voted on patch set 7 V +1 08/09/25, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83061

  23. Friedemann Altrock voted on patch set 7 CR +1 V +1 08/09/25, 16:16

  24. Simon Schaufelberger uploaded patch set 8 CR +1 V +1 08/09/25, 22:26

  25. Simon Schaufelberger voted on patch set 8 CR +1 V +1 08/09/25, 22:33

  26. core-ci voted on patch set 8 V +1 08/09/25, 22:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83075

  1. Friedemann Altrock voted on patch set 8 CR +1 V +1 08/10/25, 10:13

  2. Sebastian Michaelsen voted on patch set 8 CR +1 08/10/25, 10:50

  3. Christian Kuhn commented on patch set 8 08/13/25, 19:42

    RecordHistory.php:34

    i think we should add an @internal to this class along the way: this stateful class is a mess and needs refactoring.

    RecordHistory.php:143

    as far as i can see, $this->element is the only class state used in this new method. i'd suggest to hand that over to the method instead of relying on it being set already to not make this class worse than it is already.
  4. Friedemann Altrock uploaded patch set 9 CR +1 V +1 08/14/25, 07:41

  5. Friedemann Altrock commented on patch set 8 CR +1 V +1 08/14/25, 07:41

    RecordHistory.php:34 Reply

    Agreed, @internal added.

    RecordHistory.php:143 Reply

    Done.
  6. core-ci voted on patch set 9 V +1 08/14/25, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83355

  7. Oli Bartsch commented on patch set 9 V -1 08/14/25, 08:55

    Unfortunately, I’m experiencing unexpected behavior with the latest patchset. Please see my screenshots in the forge issue.

    RecordHistory.php:138

    This can be skipped.

    RecordHistory.php:178

    Let's use GeneralUtility:makeInstance() to create those instances.
  8. Friedemann Altrock uploaded patch set 10 V +1 08/15/25, 09:46

  9. Friedemann Altrock commented on patch set 9 08/15/25, 09:46

    Reply

    Could not reproduce - can you attach a DB dump to the issue?

    RecordHistory.php:138 Reply

    Done

    RecordHistory.php:178 Reply

    Done
  10. core-ci voted on patch set 10 V +1 08/15/25, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83445

  11. Sebastian Michaelsen uploaded patch set 11 V +1 03/20/26, 08:53

  12. Sebastian Michaelsen commented on patch set 11 03/20/26, 08:56

    Reply

    I rebased the change to resolve merge conflicts and I wasn't able to reproduce the issue. If you have any guidance on how to reproduce the issue, I'd be happy to look into it.
  13. core-ci voted on patch set 11 V +1 03/20/26, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98273

  14. Oli Bartsch commented on patch set 11 03/23/26, 13:58

    Reply

    Hey, I'm sorry for this late reply. I can not reproduce this currently. I'll therefore resolve this comment.
  15. Sebastian Michaelsen voted on patch set 11 CR +1 V +1 03/24/26, 08:09

  16. Simon Schaufelberger voted on patch set 11 CR +1 V +1 03/24/26, 14:30

  17. Guido Schmechel commented on patch set 11 03/28/26, 18:28

    Overall, I was able to test the feature successfully. Even an editor could only see the languages they were authorised to view. Great. For the sake of consistency, I would simply move the button into the breadcrumb, just as with the PageLayout. See example

    ElementHistoryController.php:268

    Example: $this->view->getDocHeaderComponent()->setLanguageSelector($languageDropDownButton);
  18. Simon Schaufelberger uploaded patch set 12 CR +1 V +1 03/30/26, 09:59

  19. Simon Schaufelberger commented on patch set 12 CR +1 V +1 03/30/26, 09:59

    ElementHistoryController.php:268 Reply

    Done
  20. core-ci voted on patch set 12 V -1 03/30/26, 10:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99029

  21. Simon Schaufelberger rebased onto patch set 13 CR +1 V +1 03/30/26, 13:27

  22. Simon Schaufelberger voted on patch set 13 CR +1 V +1 03/30/26, 13:28

  23. core-ci voted on patch set 13 V +1 03/30/26, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99063

  24. Georg Ringer voted on patch set 13 CR +2 V +2 03/30/26, 14:42

  25. Georg Ringer merged patch set 14 03/30/26, 14:42