Review main Merged

90276[BUGFIX] Streamline FileList sorting naming and type consistency

Oli Bartsch CR +2 V +2 Normal +100 −35 updated 08/09/25, 07:05

Commit message

Sorting in the FileList has been reworked in #105952.

However, the underlying functionality in the
`AbstractResourceBrowser` uses different naming
for the sort field and sort direction.

This discrepancy is now resolved by streamlining
the FileList to consistently use "sortField" and
"sortDirection".

Additionally, instead of boolean or 0/1 integer
values, the sort direction is now always defined
via the SortDirection enum for improved type
safety and clarity.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 9

Review log 2028

Show 23 earlier messages
  1. Oli Bartsch uploaded patch set 1 08/07/25, 20:26

  2. core-ci voted on patch set 1 V +1 08/07/25, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82920

  3. Oli Bartsch updated the commit message in patch set 2 V +1 08/08/25, 07:37

  1. core-ci voted on patch set 2 V +1 08/08/25, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82988

  2. Andreas Kienast commented on patch set 2 08/08/25, 07:50

    FileList.php:237

    I think we should still allow bool values for legacy reasons, _albeit_ this class is internal. I may assume that there are usages in extensions due to lacking of non-internal APIs. However, let's deprecate bool values in v14.
  3. Oli Bartsch uploaded patch set 3 V +1 08/08/25, 08:07

  4. Oli Bartsch uploaded patch set 4 08/08/25, 08:12

  5. core-ci voted on patch set 3 V -1 08/08/25, 08:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82992

  6. Oli Bartsch uploaded patch set 5 08/08/25, 08:21

  7. core-ci voted on patch set 4 V -1 08/08/25, 08:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82995

  8. core-ci voted on patch set 5 V +1 08/08/25, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82997

  9. Oli Bartsch commented on patch set 5 08/08/25, 08:38

    FileList.php:237 Reply

    Done
  10. Oliver Klee commented on patch set 5 08/08/25, 10:58

    Part of the sentence seems to be missing here.
  11. Andreas Kienast updated the commit message in patch set 6 V +1 08/08/25, 13:20

  12. Andreas Kienast commented on patch set 6 CR -1 08/08/25, 13:21

    Will refine the ReST

    Reply

    Starting a new line with the ticket id is a bad idea...
  13. Andreas Kienast uploaded patch set 7 CR -1 08/08/25, 13:24

  14. Andreas Kienast voted on patch set 7 CR +1 V +1 08/08/25, 13:24

  15. core-ci voted on patch set 6 V +1 08/08/25, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83019

  16. core-ci voted on patch set 7 V -1 08/08/25, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83020

  17. Oliver Klee commented on patch set 7 08/08/25, 14:29

    Reply

    Indeed - I got bitten by this a few days ago as well. :-)
  18. Oli Bartsch uploaded patch set 8 CR +1 V +1 08/08/25, 15:40

  19. Andreas Kienast voted on patch set 8 CR +1 V +1 08/08/25, 15:42

  20. core-ci voted on patch set 8 V +1 08/08/25, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83022

  21. Simon Schaufelberger commented on patch set 8 08/08/25, 20:41

    A bugfix with a backport to v13 but the changelog for v14? I'm confused...
  22. Andreas Kienast commented on patch set 8 08/08/25, 22:49

    Reply

    The deprecation is for v14 only and of course not backported to v13.
  23. Simon Schaufelberger commented on patch set 8 CR +1 V +1 08/09/25, 06:30

    Reply

    Acknowledged
  24. Oli Bartsch voted on patch set 8 CR +2 V +2 08/09/25, 07:05

  25. Oli Bartsch merged patch set 9 08/09/25, 07:05