90276[BUGFIX] Streamline FileList sorting naming and type consistency
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 9
- typo3/sysext/core/Documentation/Changelog/14.0/Deprecation-107225-BooleanSortDirectionInFileListStart.rstnew+62 −0
- typo3/sysext/filelist/Classes/Controller/FileListController.php+8 −8
- typo3/sysext/filelist/Classes/ElementBrowser/CreateFolderBrowser.php+1 −2
- typo3/sysext/filelist/Classes/ElementBrowser/FileBrowser.php+1 −2
- typo3/sysext/filelist/Classes/ElementBrowser/FolderBrowser.php+1 −2
- typo3/sysext/filelist/Classes/LinkHandler/FileLinkHandler.php+1 −2
- typo3/sysext/filelist/Classes/LinkHandler/FolderLinkHandler.php+1 −2
- typo3/sysext/filelist/Classes/FileList.php2+23 −15
- typo3/sysext/filelist/Configuration/Backend/Modules.php+2 −2
Review log 2028
Show 23 earlier messages
-
Oli Bartsch uploaded patch set 1 08/07/25, 20:26
-
core-ci voted on patch set 1 V +1 08/07/25, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82920
-
Oli Bartsch updated the commit message in patch set 2
V +108/08/25, 07:37
-
core-ci voted on patch set 2 V +1 08/08/25, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82988
-
Andreas Kienast commented on patch set 2 08/08/25, 07:50
-
Oli Bartsch uploaded patch set 3
V +108/08/25, 08:07 -
Oli Bartsch uploaded patch set 4 08/08/25, 08:12
-
core-ci voted on patch set 3 V -1 08/08/25, 08:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82992
-
Oli Bartsch uploaded patch set 5 08/08/25, 08:21
-
core-ci voted on patch set 4 V -1 08/08/25, 08:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82995
-
core-ci voted on patch set 5 V +1 08/08/25, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82997
-
Oli Bartsch commented on patch set 5 08/08/25, 08:38
FileList.php:237ReplyDone -
Oliver Klee commented on patch set 5 08/08/25, 10:58
Part of the sentence seems to be missing here. -
Andreas Kienast updated the commit message in patch set 6
V +108/08/25, 13:20 -
Andreas Kienast commented on patch set 6 CR -1 08/08/25, 13:21
Will refine the ReSTReply
Starting a new line with the ticket id is a bad idea... -
Andreas Kienast uploaded patch set 7
CR -108/08/25, 13:24 -
Andreas Kienast voted on patch set 7 CR +1 V +1 08/08/25, 13:24
-
core-ci voted on patch set 6 V +1 08/08/25, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83019
-
core-ci voted on patch set 7 V -1 08/08/25, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83020
-
Oliver Klee commented on patch set 7 08/08/25, 14:29
Reply
Indeed - I got bitten by this a few days ago as well. :-) -
Oli Bartsch uploaded patch set 8
CR +1V +108/08/25, 15:40 -
Andreas Kienast voted on patch set 8 CR +1 V +1 08/08/25, 15:42
-
core-ci voted on patch set 8 V +1 08/08/25, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83022
-
Simon Schaufelberger commented on patch set 8 08/08/25, 20:41
A bugfix with a backport to v13 but the changelog for v14? I'm confused... -
Andreas Kienast commented on patch set 8 08/08/25, 22:49
Reply
The deprecation is for v14 only and of course not backported to v13. -
Simon Schaufelberger commented on patch set 8 CR +1 V +1 08/09/25, 06:30
Reply
Acknowledged -
Oli Bartsch voted on patch set 8 CR +2 V +2 08/09/25, 07:05
-
Oli Bartsch merged patch set 9 08/09/25, 07:05
FileList.php:237