90281[BUGFIX] Don't use label fallback in page module
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- core-ci +1 CI
Issues 2
Files 1
Review log 89
-
Lisa Kreitz uploaded patch set 1 08/07/25, 20:49
-
Georg Ringer voted on patch set 1 CR +1 V +1 08/07/25, 20:54
-
core-ci voted on patch set 1 V +1 08/07/25, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82929
-
Oli Bartsch commented on patch set 1 08/07/25, 21:26
-
Georg Ringer commented on patch set 1 08/07/25, 21:28
StandardContentPreviewRenderer.php:77Replynot really sure, subheader is always shown below if available. so this is somehow wrong as soon as BU::recordTitle is used. So as alternative maybe even drop the subheader rendering completly? -
Oli Bartsch commented on patch set 1 08/07/25, 22:09
StandardContentPreviewRenderer.php:77ReplySure. So my suggestion was to drop the static rendering and use `primaryField` as well as iterating over `getAdditionalFieldNames()`. However, `bodytext` is defined as `label_alt`. So we might manually filter this list? Actually, the right approach would be to render `getAdditionalFieldNames()` only if `alwaysRenderAdditionalFields()` is `true`. But for `tt_content`, that is not the case by default and we would lose `subheader`. Not quite sure currently. Will need to think about this again. What is your opinion? -
Georg Ringer commented on patch set 1 08/09/25, 07:25
StandardContentPreviewRenderer.php:77ReplyI did the patch together with Lisa, IMO this is best way to have the state like before. In the longrun we should look at the preview of all content elements and then we can also e.g. remove bodytext from the label_alt and improve the rendering but this is out of scrope. -
Oli Bartsch commented on patch set 1 CR +2 V +2 08/09/25, 07:41
StandardContentPreviewRenderer.php:77ReplyAcknowledged -
Oli Bartsch merged patch set 2 08/09/25, 07:41
StandardContentPreviewRenderer.php:77