Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
90283[TASK] Avoid saving site settings/config if no value has changed
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 12
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/83/90283/12 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/83/90283/12 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Simon Schaufelberger +1
-
Verified V +1 Needs a vote
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php10+55 −4
- typo3/sysext/backend/Classes/Controller/SiteSettingsController.php+8 −2
- typo3/sysext/backend/Resources/Private/Language/locallang_siteconfiguration.xlf+9 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_sitesettings.xlf+3 −0
Review log 2335
Show 710 earlier messages
-
Benjamin Franzke uploaded patch set 1 08/07/25, 21:42
-
core-ci voted on patch set 1 V +1 08/07/25, 22:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82945
-
Oli Bartsch commented on patch set 1 08/07/25, 22:31
Two thought on that: 1. Not quite sure if "info" is the correct severity here. IMO info is mostly used for permanent information, e.g. "Please select a page in the page tree to edit page content." 2. For consistency with e.g. FormEngine, we might should render a "success" notification when saving was successful. Just checked site configuration module, there this is also missing. What do you think? -
Sven Liebert uploaded patch set 2
V +110/23/25, 19:54 -
Sven Liebert commented on patch set 2 10/23/25, 19:55
Reply
1. should be a warning IMO, because the user want's to change something (otherwise he shouldn't use the "Save" button. 2. Added the success message to site configuration module. In site settings there is already a success message -
core-ci voted on patch set 2 V +1 10/23/25, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87444
-
Oli Bartsch commented on patch set 2 10/24/25, 13:56
SiteConfigurationController.php:432Currently this is also shown on save, even if nothing has been changed. Can we detect this and also add a corresponding message? -
Sven Liebert uploaded patch set 3
V +110/24/25, 14:53 -
Sven Liebert commented on patch set 3 10/24/25, 14:53
SiteConfigurationController.php:432ReplyDone -
core-ci voted on patch set 3 V -1 10/24/25, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87517
-
Sven Liebert uploaded patch set 4
V -110/24/25, 15:04 -
core-ci voted on patch set 4 V +1 10/24/25, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87518
-
Garvin Hicking uploaded patch set 5
V +101/25/26, 00:06 -
Garvin Hicking commented on patch set 5 01/25/26, 00:09
SiteConfigurationController.php:571I don't understand this one, it's a noop? Return isn't used? But when saving arrays (like dependencies / languages) it seems to detect the changes properly. I would've thought it would need a ``` if ($this->isConfigurationChanged($oldConfiguration[$key], $value)) { return true; } ``` but that doesn't seem needed. And if that's the case, the whole method doesn't need to be called? There's also no call-by-reference involved? Please shed a light :D -
core-ci voted on patch set 5 V +1 01/25/26, 00:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94274
-
Simon Schaufelberger commented on patch set 5 01/25/26, 00:46
SiteConfigurationController.php:524why create a new instance when you could also use the existing one that is injected?SiteConfigurationController.php:541why create a new instance when you could also use the existing one that is injected? -
Sven Liebert wrote 03/24/26, 06:41
Removed cc Sven Liebert. -
Benni Mack updated the commit message in patch set 6
V +104/22/26, 06:43 -
core-ci voted on patch set 6 V -1 04/22/26, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100776
-
Benni Mack rebased onto patch set 7
V -109/04/26, 13:29 -
core-ci voted on patch set 7 V +1 09/04/26, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107880
-
Benjamin Franzke uploaded patch set 8
V +109/11/26, 14:14 -
Benjamin Franzke commented on patch set 8 09/11/26, 14:14
Reply
Let's use INFO here, since the most important fact for the user is that everything is up-to-date. I even asked Gemini ;) > Q: should a "no changes" message be a warning or info severity? > R: A "no changes" message should almost always be set to info severity.Warnings are meant for things that might be a problem, like low battery or a missing file. When a user runs a process and nothing changes, it usually just means everything is already up to date. It is a successful result, not a problem!SiteConfigurationController.php:524Replyack, happened in a patch update by someone else: https://review.typo3.org/c/Packages/TYPO3.CMS/+/90283/1..2 I guess copy&paste mistake. Fixed.SiteConfigurationController.php:541ReplySame as above.SiteConfigurationController.php:571ReplyNot my code, because it has been added by Sven in https://review.typo3.org/c/Packages/TYPO3.CMS/+/90283/1..5 (this patch initially only fixed the site settings editor, not the site configuration). But good catch, it needs a `return` statement, since the intention is to compare nested. Fixed. -
core-ci voted on patch set 8 V -1 09/11/26, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108301
-
Benjamin Franzke rebased onto patch set 9
V -109/11/26, 21:59 -
core-ci voted on patch set 9 V -1 09/11/26, 22:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108324
-
Benjamin Franzke rebased onto patch set 10
V -109/15/26, 11:58 -
core-ci voted on patch set 10 V -1 09/15/26, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108616
-
Benjamin Franzke uploaded patch set 11
V -109/15/26, 13:14 -
core-ci voted on patch set 11 V +1 09/15/26, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108621
-
Simon Schaufelberger commented on patch set 11 09/15/26, 14:06
SiteConfigurationController.php:542can we use the new short syntax? I have written a rector rule to migrate that and i can run over the patch if you want. -
Benjamin Franzke uploaded patch set 12
V +109/15/26, 14:34 -
Benjamin Franzke commented on patch set 12 09/15/26, 14:34
SiteConfigurationController.php:542Replysure, done. -
core-ci voted on patch set 12 V +1 09/15/26, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108630
-
Simon Schaufelberger voted on patch set 12 CR +1 V +1 09/15/26, 16:29