Review main Merged

90289[TASK] Add functional test for ViewFactory

Simon Praetorius CR +2 V +2 Hard +262 −0 updated 08/12/25, 18:44

Commit message

One purpose of the `ViewFactoryInterface`, which was introduced
with v13, is to replace a View of a service with a custom
implementation via dependency injection. This patch adds a
functional test that covers this use case.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 2533

Show 78 earlier messages
  1. Simon Praetorius uploaded patch set 1 08/08/25, 07:50

  2. core-ci voted on patch set 1 V +1 08/08/25, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82991

  3. Oliver Klee voted on patch set 1 V +1 08/08/25, 08:09

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 08/08/25, 20:47

  5. Stefan Bürk commented on patch set 1 CR -1 08/10/25, 23:47

    Going to add some comments to the fixture extension code, just in case people may use that as example but replaceing "default" ViewFactory implentation in a broader scope which should use then the `service decorator pattern). Don't get me wrong, the fixture extension demostrated implementing a custom viewfactory for a dedicated use in that extension. I just want to make that clear for people not understanding DI and the code correctly and simply copy&pasting code. On it (tomorrow) ...
  6. Simon Praetorius commented on patch set 1 08/11/25, 06:51

    Reply

    Great idea, thanks!
  7. Simon Praetorius commented on patch set 1 08/11/25, 06:52

    Reply

    Done
  8. Stefan Bürk uploaded patch set 2 CR +1 V +1 08/11/25, 14:21

  1. Oliver Klee voted on patch set 2 V +1 08/11/25, 14:23

  2. core-ci voted on patch set 2 V +1 08/11/25, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83149

  3. Stefan Bürk voted on patch set 2 CR +1 V +1 08/11/25, 14:33

  4. Simon Praetorius uploaded patch set 3 CR +1 V +1 08/11/25, 15:34

  5. core-ci voted on patch set 3 V -1 08/11/25, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83150

  6. Stefan Bürk commented on patch set 4 V -1 08/11/25, 18:33

    Published edit on patch set 3.
  7. core-ci voted on patch set 4 V -1 08/11/25, 18:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83152

  8. Simon Praetorius commented on patch set 4 08/11/25, 18:42

    ext_emconf.php:17

    maybe also set to `*` here?
  9. Stefan Bürk commented on patch set 4 08/12/25, 00:03

    ext_emconf.php:17 Reply

    Nope and my change not needed at all. It's a hickup in the `checkComposer` integrity check. Test fixture extensins are not in root composer.json require/require-dev section when found in a `composer.json` (systemextension or test-fixture extension in tests subfolder) as require or require dev. System extensions are already ignored for checking if root composer.json has all 3rd party components listed. As we have now two test-fixture extensions where one requires the other one, that fails now. I'd say we need to skip test-fixture extensions composer package names (`typo3tests/*`) to not require them in the root composer.json. Will recheck that tomorrow and pushing a pre-change, so stay tuned.
  10. Stefan Bürk rebased onto patch set 5 V -1 08/12/25, 08:37

  11. Stefan Bürk updated the commit message in patch set 6 08/12/25, 08:37

  12. Stefan Bürk uploaded patch set 7 08/12/25, 08:38

  13. core-ci voted on patch set 6 V +1 08/12/25, 08:51 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 7 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83185

  14. core-ci voted on patch set 5 V +1 08/12/25, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83183

  15. core-ci voted on patch set 7 V +1 08/12/25, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83187

  16. Stefan Bürk commented on patch set 7 08/12/25, 09:04

    ext_emconf.php:17 Reply

    Set to wip for the timebeeing, needs https://review.typo3.org/c/Packages/TYPO3.CMS/+/90336 to be merged first.
  17. Oliver Klee voted on patch set 7 V +1 08/12/25, 09:24

  18. Stefan Bürk uploaded patch set 8 V +1 08/12/25, 12:29

  19. Stefan Bürk commented on patch set 8 08/12/25, 12:30

    ext_emconf.php:17 Reply

    Done
  20. core-ci voted on patch set 8 V +1 08/12/25, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83201

  21. Oliver Klee voted on patch set 8 V +1 08/12/25, 13:04

  22. Stefan Bürk voted on patch set 8 CR +1 V +1 08/12/25, 15:31

  23. Garvin Hicking commented on patch set 8 CR +1 V +1 08/12/25, 16:30

    Shiny!
  24. Christian Kuhn voted on patch set 8 CR +2 V +2 08/12/25, 18:38

  25. Christian Kuhn merged patch set 9 08/12/25, 18:44