Review 13.4 Merged

90290[BUGFIX] Streamline FileList sorting naming and type consistency

Oli Bartsch CR +2 V +2 Normal +36 −36 updated 08/09/25, 07:06

Commit message

Sorting in the FileList has been reworked in

However, the underlying functionality in the
`AbstractResourceBrowser` uses different naming
for the sort field and sort direction.

This discrepancy is now resolved by streamlining
the FileList to consistently use "sortField" and
"sortDirection".

Additionally, instead of boolean or 0/1 integer
values, the sort direction is now always defined
via the SortDirection enum for improved type
safety and clarity.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 8

Review log 58

  1. Oli Bartsch uploaded patch set 1 08/08/25, 08:10

  2. Oli Bartsch uploaded patch set 2 08/08/25, 08:12

  3. core-ci voted on patch set 1 V -1 08/08/25, 08:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82993

  4. Oli Bartsch uploaded patch set 3 08/08/25, 08:22

  5. core-ci voted on patch set 2 V -1 08/08/25, 08:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82994

  6. core-ci voted on patch set 3 V +1 08/08/25, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82998

  7. Oli Bartsch voted on patch set 3 CR +2 V +2 08/09/25, 07:06

  8. Oli Bartsch merged patch set 4 08/09/25, 07:06