Review main Merged

90292[BUGFIX] Respect selectMultipleSideBySide in custom fields of site configuration

Georg Ringer CR +2 V +2 Easy +34 −12 updated 08/13/25, 21:52

Commit message

Replace the hardcoded usage for the field `dependencies` with a check
of the type and renderType to allow TCA type "select" with renderType
"selectMultipleSideBySide" for custom fields in site configuration.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1115

  1. Georg Ringer uploaded patch set 1 08/08/25, 08:23

  2. Georg Ringer commented on patch set 1 08/08/25, 08:23

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 08/08/25, 08:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82999

  4. Georg Ringer uploaded patch set 2 V -1 08/08/25, 09:10

  5. core-ci voted on patch set 2 V +1 08/08/25, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83003

  6. Oliver Klee updated the commit message in patch set 3 V +1 08/08/25, 10:57

  7. core-ci voted on patch set 3 V +1 08/08/25, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83008

  8. Simon Schaufelberger voted on patch set 3 CR +1 V +1 08/09/25, 06:38

  9. Oli Bartsch commented on patch set 3 V -1 08/13/25, 16:47

    The added test does not verify the change.
  10. Oli Bartsch uploaded patch set 4 CR +1 V +1 08/13/25, 16:49

  11. Oli Bartsch commented on patch set 4 CR +1 V +1 08/13/25, 16:50

    Reply

    Done
  12. core-ci voted on patch set 4 V +1 08/13/25, 16:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83316

  13. Christian Kuhn voted on patch set 4 CR +1 V +1 08/13/25, 19:03

  14. Oli Bartsch voted on patch set 4 CR +2 V +2 08/13/25, 21:52

  15. Oli Bartsch merged patch set 5 08/13/25, 21:52