90293[TASK] Clarify internal error handling for 500 and 503
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oliver Klee +1
- Sebastian Michaelsen +1
- Stefan Bürk +1
- Sven Liebert +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1314
-
Friedemann Altrock uploaded patch set 1 08/08/25, 08:25
-
Sebastian Michaelsen voted on patch set 1 CR +1 08/08/25, 08:34
-
Sven Liebert voted on patch set 1 CR +1 08/08/25, 08:38
-
core-ci voted on patch set 1 V +1 08/08/25, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83000
-
Benni Mack voted on patch set 1 CR +1 V +1 08/09/25, 09:25
-
Georg Ringer voted on patch set 1 CR +1 V +1 08/09/25, 09:42
-
Garvin Hicking commented on patch set 1 CR -1 08/10/25, 17:57
-
Stefan Bürk commented on patch set 1 08/10/25, 22:32
ErrorController.php:118ReplyNot sure if there are use-cases for xclassing the ErrorController at all. I see use-cases more in the usage of the `ErrorController` to call the public methods. I'd put protected methods in the category `@internal`, but yeah .. if class is xclassed and public method overriden to change the behavior, it may be breaking. But then, xlassing for classes not explictly declared as api (extending) is considered non-breaking by the policy ... Taking all into account, I would say that this is considerable non-breaking albeit technically breaking in xclass scenarios. -
Stefan Bürk commented on patch set 1 CR +1 V +1 08/10/25, 22:32
ErrorController.php:118Reply+ it's main only and not target for backport into a LTS version. -
Benni Mack commented on patch set 1 08/11/25, 07:07
ErrorController.php:118Replyprotected methods' only extensibility is XCLASSing. Even for LTS versions, this is not a breaking change at all. XCLASSes are not covered by our bc promise, so I'd be much more careful in v13 backports. However - additionally - this change is not critical at all (= not many people would even XCLASS this code or method). -
Garvin Hicking commented on patch set 1 CR 0 08/11/25, 07:35
ErrorController.php:118ReplyAlright. Guess I also mkxed this up as ErrorHandler vs ErrorControllsr. Thanks for the explanations. :) -
Oliver Klee voted on patch set 1 CR +1 V +1 08/11/25, 07:35
-
Benni Mack voted on patch set 1 CR +2 V +2 08/11/25, 07:38
-
Benni Mack merged patch set 2 08/11/25, 07:38
ErrorController.php:118