Review main Merged

90294[BUGFIX] Respect system time zone in history module

Sebastian Michaelsen CR +2 V +2 Easy +5 −2 updated 08/22/25, 15:24

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Froemken +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 3037

Show 912 earlier messages
  1. Sebastian Michaelsen uploaded patch set 1 08/08/25, 08:29

  2. Sven Liebert commented on patch set 1 CR -1 08/08/25, 08:37

    I think we should not hardcode the format to german format.
  3. core-ci voted on patch set 1 V +1 08/08/25, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83001

  4. Sven Liebert commented on patch set 1 08/08/25, 08:54

    Reply

    Unresolved.
  5. Sebastian Michaelsen uploaded patch set 2 CR -1 V +1 08/08/25, 08:57

  6. Friedemann Altrock voted on patch set 2 CR +1 V +1 08/08/25, 09:03

  7. core-ci voted on patch set 2 V +1 08/08/25, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83002

  8. Sebastian Michaelsen updated the commit message in patch set 3 CR +1 V +1 08/08/25, 09:22

  9. core-ci voted on patch set 3 V +1 08/08/25, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83004

  10. Friedemann Altrock voted on patch set 3 CR +1 V +1 08/08/25, 10:13

  11. Sebastian Michaelsen commented on patch set 3 08/08/25, 10:19

    Reply

    Done
  12. Benni Mack commented on patch set 3 08/08/25, 11:21

    ElementHistoryController.php:322

    wdyt of using DateTimeFactory::createFromTimestamp()?
  1. Sebastian Michaelsen uploaded patch set 4 CR +1 V +1 08/08/25, 13:36

  2. Sebastian Michaelsen commented on patch set 4 08/08/25, 13:36

    ElementHistoryController.php:322 Reply

    I can do that, but I will still pass it to the DateViewHelper in the same way and don't seem to gain anything from the conversion.
  3. Friedemann Altrock commented on patch set 4 08/08/25, 13:39

    ElementHistoryController.php:323

    If we create a DateTime object anyway, why not combine the `day` and `time` fields?
  4. Friedemann Altrock commented on patch set 4 08/08/25, 13:40

    ElementHistoryController.php:323 Reply

    Done, dumb suggestion, as BackendUtility::date does more stuff.
  5. core-ci voted on patch set 4 V +1 08/08/25, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83021

  6. René Pflamm voted on patch set 4 CR +1 08/08/25, 14:56

  7. Simon Schaufelberger voted on patch set 4 CR +1 V +1 08/09/25, 06:33

  8. Sven Liebert voted on patch set 4 CR +1 08/09/25, 06:44

  9. Benni Mack uploaded patch set 5 CR +1 V +1 08/12/25, 13:36

  10. core-ci voted on patch set 5 V +1 08/12/25, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83205

  11. Sebastian Michaelsen voted on patch set 5 CR +1 V +1 08/12/25, 14:55

  12. René Pflamm voted on patch set 5 CR +1 08/12/25, 15:01

  13. Garvin Hicking voted on patch set 5 CR +1 V +1 08/12/25, 17:55

  14. Benni Mack commented on patch set 5 CR -1 08/13/25, 07:34

    I'm not sure about this one. Using date() now in "default" (= english) shows US-date format. But ONLY on this place. I wonder if we should either a) only focus on the timezone and handle locale in a separate patch in multiple places for main only b) or roll this out everywhere where BackendUtility::time() is used, and analyze how to switch from US time format to UK time format when using DateTime MEDIUMTIME
  15. Garvin Hicking commented on patch set 5 CR 0 V 0 08/13/25, 08:44

    Reply

    Ah good point. `::time` is actually only used in three places (one from this patch, two in FormEngine, but where I figured the 'time' would really be needed due to SQL ops). Hm, thinking about this, maybe we should have a user preference for time format then, and maybe even date format? But that is a large scope.
  16. Sebastian Michaelsen commented on patch set 5 08/13/25, 09:59

    Even though I think having the time format set by the current locale (which already considers the user’s language) is right or at least better than the status quo, I acknowledge that it’s worth a separate discussion and would be okay to only fix the time zone issue.
  17. Garvin Hicking commented on patch set 5 08/13/25, 11:10

    Reply

    Yes please, let's reduce the scope (sorry for back and forth). Sadly "english" locale doesnt easily cover US va UK as to a preferrence of times, since we only have "english" as a collective language without further subtypes as a backend language.
  18. Sebastian Michaelsen uploaded patch set 6 CR +1 V +1 08/18/25, 10:06

  19. Sebastian Michaelsen updated the commit message in patch set 7 08/18/25, 10:08

  20. core-ci voted on patch set 6 V +1 08/18/25, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83563

  21. core-ci voted on patch set 7 V +1 08/18/25, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83564

  22. Garvin Hicking voted on patch set 7 CR +1 V +1 08/18/25, 12:43

  23. Stefan Froemken commented on patch set 7 CR +1 V +1 08/22/25, 10:30

    Perfect! The resulting 'timezone_type' is 3, which can also differentiate between summer and winter time.
  24. Christian Kuhn voted on patch set 7 CR +2 V +2 08/22/25, 15:15

  25. Christian Kuhn merged patch set 8 08/22/25, 15:24