Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
90295[BUGFIX] Fix char counter partially hidden in IRRE elements
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/95/90295/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/95/90295/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 3
Review log 58
-
Marcel Küpper uploaded patch set 1 08/08/25, 11:02
-
core-ci voted on patch set 1 V +1 08/08/25, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83009
-
Simon Schaufelberger updated the commit message in patch set 2
V +108/09/25, 06:35 -
core-ci voted on patch set 2 V +1 08/09/25, 06:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83042
-
Oli Bartsch uploaded patch set 3
V +108/13/25, 16:57 -
Oli Bartsch commented on patch set 3 08/13/25, 17:01
I've added a styleguide example to showcase the current behaviour. While your patch works, I wonder why the min chars message and the max chars message to not use the same component. Min char message does not have this problem. Instead of fixing it, what do you think about unifying the message component? cc @benjamin.kott@outlook.com -
core-ci voted on patch set 3 V +1 08/13/25, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83317
-
Marcel Küpper commented on patch set 3 08/13/25, 17:54
Reply Unresolved
Already mentioned in the ticket, that my initial patch set is not a suitable solution. Talked with Andreas Nedbal and Garvin Hicking about this during the dev days. Also stumbled over the min char thing and that the .form-hint styling only seems to be used in this single context. Just didn't found the time to look further into this yet. And you're absolutely right, both should use the same component of course. Can have a look later this week if you like. I'm not upset if someone else would rather take care of it. Just let me know.