90296[FEATURE] Use properties for configuration of Extbase attributes
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Torben Hansen +1
- Lina Wolf +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Torben Hansen +1
- Lina Wolf +1
- core-ci +1 CI
Issues 2
Files 40
- typo3/sysext/beuser/Classes/Domain/Model/BackendUser.php+1 −1
- typo3/sysext/beuser/Classes/Domain/Model/FileMount.php+1 −1
- typo3/sysext/core/Documentation/Changelog/14.0/Deprecation-97559-DeprecatePassingAnArrayOfConfigurationValuesToExtbaseAttributes.rstnew+125 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-97559-UsePropertiesForConfigurationOfExtbaseAttributes.rst5new+63 −0
- typo3/sysext/extbase/Classes/Attribute/ORM/Cascade.php+23 −10
- typo3/sysext/extbase/Classes/Attribute/FileUpload.php+51 −24
- typo3/sysext/extbase/Classes/Attribute/IgnoreValidation.php+19 −9
- typo3/sysext/extbase/Classes/Attribute/Validate.php+27 −19
- typo3/sysext/extbase/Classes/Domain/Model/Category.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/action_controller_argument_test/Classes/Controller/ArgumentTestController.php+2 −8
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/action_controller_test/Classes/Controller/TestController.php+2 −8
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/BlogController.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/BlogPostEditingController.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Blog.php+4 −4
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Category.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Comment.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Post.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/RestrictedComment.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Classes/Controller/SingleFileUploadController.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Classes/Domain/Model/Singlefile.php+60 −60
Show 20 more files
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/file_upload/Classes/Domain/Model/Dto/FileUploadObjectStorageUploadedFile.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/file_upload/Classes/Domain/Model/FileReferencePropertyMultiple.php+4 −4
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/file_upload/Classes/Domain/Model/FileReferencePropertySingle.php+4 −4
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/file_upload/Classes/Domain/Model/FileUploadMultipleProperties.php+8 −8
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Classes/Domain/Model/Main.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/Domain/Model/AliasedModel.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/Domain/Model/AnotherModel.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/Domain/Model/MixedSymfonyModel.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/Domain/Model/Model.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Attribute/ORM/CascadeTest.phpnew+42 −0
- typo3/sysext/extbase/Tests/Unit/Attribute/FileUploadTest.phpnew+66 −0
- typo3/sysext/extbase/Tests/Unit/Attribute/IgnoreValidationTest.phpnew+42 −0
- typo3/sysext/extbase/Tests/Unit/Attribute/ValidateTest.phpnew+48 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithAllTypesOfProperties.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithIgnoreValidationAttribute.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyController.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyControllerWithIgnoreValidationAttributes.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyControllerWithValidateAttributeWithoutParam.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyControllerWithValidateAttributeWithoutParamTypeHint.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyModel.php+16 −16
Review log 3042
Show 1017 earlier messages
-
Elias Häußler uploaded patch set 1 08/08/25, 12:53
-
Elias Häußler updated the commit message in patch set 2 08/08/25, 12:54
-
core-ci voted on patch set 2 V -1 08/08/25, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83018
-
Elias Häußler wrote 08/21/25, 06:55
Topic set to extbase -
Elias Häußler uploaded patch set 3
V -110/10/25, 08:18 -
core-ci voted on patch set 3 V -1 10/10/25, 08:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86366
-
Elias Häußler uploaded patch set 4
V -110/13/25, 14:25 -
core-ci voted on patch set 4 V -1 10/13/25, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86548
-
Elias Häußler uploaded patch set 5
V -110/14/25, 12:56 -
core-ci voted on patch set 5 V -1 10/14/25, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86629
-
Elias Häußler uploaded patch set 6
V -110/14/25, 14:01 -
core-ci voted on patch set 6 V +1 10/14/25, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86636
-
Elias Häußler uploaded patch set 7
V +110/14/25, 15:06 -
Elias Häußler marked it ready for review 10/14/25, 15:07
-
Elias Häußler uploaded patch set 8 10/14/25, 15:12
-
core-ci voted on patch set 7 V -1 10/14/25, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86644
-
core-ci voted on patch set 8 V +1 10/14/25, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86646
-
Elias Häußler uploaded patch set 9
V +110/14/25, 15:24 -
core-ci voted on patch set 9 V +1 10/14/25, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86648
-
Elias Häußler updated the commit message in patch set 10
V +110/14/25, 19:53 -
core-ci voted on patch set 10 V +1 10/14/25, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86656
-
Oliver Klee voted on patch set 10 V +1 10/15/25, 07:10
-
Benni Mack commented on patch set 10 10/21/25, 15:48
Feature-97559-UsePropertiesForConfigurationOfExtbaseAttributes.rst:6shouldn't it be called "Use attributes for configuration of Extbase properties"? -
Elias Häußler commented on patch set 10 11/10/25, 09:09
Feature-97559-UsePropertiesForConfigurationOfExtbaseAttributes.rst:6ReplyThis patch changes construction of attribute properties from a single array to multiple properties: **Before:** ```php #[Validate([ 'validator' => 'NotEmpty', 'options' => [ 'nullMessage' => 'Value must not be empty.', ], ]) ``` **After:** ```php #[Validate( validator: 'NotEmpty', options: [ 'nullMessage' => 'Value must not be empty.', ] ) ``` Hence, I'd say the title is correct as-is. But I'm of course open to a more precise naming. -
Torben Hansen voted on patch set 10 CR +1 V +1 11/13/25, 20:59
-
Lina Wolf commented on patch set 10 11/14/25, 03:46
Feature-97559-UsePropertiesForConfigurationOfExtbaseAttributes.rst:6```suggestion Feature: #97559 - Support property-based configuration for Extbase attributes ``` -
Elias Häußler uploaded patch set 11
CR +1V +111/14/25, 07:30 -
Elias Häußler commented on patch set 11 11/14/25, 07:31
Feature-97559-UsePropertiesForConfigurationOfExtbaseAttributes.rst:6ReplyDone -
core-ci voted on patch set 11 V -1 11/14/25, 07:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89655
-
Elias Häußler uploaded patch set 12
V -111/14/25, 07:58 -
core-ci voted on patch set 12 V +1 11/14/25, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89658
-
Elias Häußler commented on patch set 12 11/14/25, 08:28
Feature-97559-UsePropertiesForConfigurationOfExtbaseAttributes.rst:6ReplyDone -
Torben Hansen voted on patch set 12 CR +1 V +1 11/14/25, 08:29
-
Oliver Klee voted on patch set 12 V +1 11/14/25, 09:00
-
Christian Kuhn rebased onto patch set 13
CR +1V +111/20/25, 12:06 -
Oliver Klee voted on patch set 13 V +1 11/20/25, 12:07
-
Torben Hansen voted on patch set 13 CR +1 V +1 11/20/25, 12:11
-
core-ci voted on patch set 13 V +1 11/20/25, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90275
-
Lina Wolf voted on patch set 13 CR +1 V +1 11/20/25, 12:14
-
Christian Kuhn voted on patch set 13 CR +2 V +2 11/20/25, 13:10
-
Christian Kuhn merged patch set 14 11/20/25, 13:10
-
Lina Wolf commented on patch set 14 12/31/25, 08:01