90304[FEATURE] Notify users on pasting password with whitespace
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/TypeScript/backend/login/pasted-password-checker.tsnew+22 −0
- Build/Sources/TypeScript/backend/tests/login/pasted-password-checker-test.tsnew+43 −0
- Build/Sources/TypeScript/backend/login.ts+31 −0
- typo3/sysext/backend/Resources/Private/Language/locallang.xlf+6 −0
- typo3/sysext/backend/Resources/Private/Layouts/Login.html5+8 −0
- typo3/sysext/backend/Resources/Public/JavaScript/login/pasted-password-checker.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/login.js+1 −1
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107240-AddWarningWhenPastingPasswordWithWhitespace.rstnew+53 −0
Review log 1924
-
Andreas Wolf uploaded patch set 1 08/09/25, 14:44
-
core-ci voted on patch set 1 V -1 08/09/25, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83070
-
Garvin Hicking uploaded patch set 2
V -108/09/25, 15:42 -
Garvin Hicking commented on patch set 2 08/09/25, 15:43
I like this! I took the liberty to remove a remainder, adjust a bit of warning, and update the build. Hope that was not overreaching, otherwise I can revert ;) I also think this would probably classify as a task (as a feature, we would need a feature RST), but happy to leave that up for discussion?Login.html:43I think for accessibility this needs to be a button -
core-ci voted on patch set 2 V +1 08/09/25, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83071
-
Andreas Wolf commented on patch set 2 08/10/25, 08:33
Reply
All fine with me. Thanks for taking care!Login.html:43ReplyYou mean 'role="button"' or actually a button? IMO adding a button would need this to be restyled, as the button should be in a separate row then and not directly appended to the text. -
Oli Bartsch commented on patch set 2 08/10/25, 11:34
Isn't this similar to https://review.typo3.org/c/Packages/TYPO3.CMS/+/88392 and could be combined? -
Oli Bartsch commented on patch set 2 08/10/25, 11:35
Reply
. -
Garvin Hicking commented on patch set 2 08/10/25, 11:56
Reply
IMO no; this patch is in the login interface and affects the comparison, the other patch about entering a password. I would keep them distinct for better reviewability.Login.html:43ReplyNot experienced enough here to answer this. I hope we can get Feedback from @benjamin.kott@outlook.com and/or from @akienast@scripting-base.de - I'd say a "full button" would be needed for the intent of an action. -
Andreas Wolf commented on patch set 2 08/10/25, 11:56
Reply
Not really IMO, since the password strength meter is for changing the password, but this one is for the login form to prevent users from wondering why their login failed after pasting a password. However, it might be good to add the same check to the other PR once this here is merged. I would just keep them separate for now since they touch two totally different areas. -
Andreas Wolf commented on patch set 2 08/10/25, 11:57
Login.html:43ReplyLet me try how that looks right now. -
Oli Bartsch commented on patch set 2 08/10/25, 16:10
Reply
Based on both are evaluating a user given password and processing it client side. I thought about we might can have a general component for this, as this makes it easier, also from a security point of view, to have only one component, doing stuff with password fields. but, I’m fine with separation as well. -
Andreas Wolf commented on patch set 2 08/11/25, 13:05
Reply
Yeah, I get that, true. But OTOH with the login we have an existing warning/error mechanism that I'm using here, and for the strength indication the feedback should be right next to the input field. So I'm not sure how we could move that into a single component? -
Oli Bartsch uploaded patch set 3
V +108/13/25, 10:14 -
Oli Bartsch uploaded patch set 4 08/13/25, 10:14
-
Oli Bartsch commented on patch set 4 CR +1 V +1 08/13/25, 10:17
Reply
You are right. This is placed in login.ts independant from any other form related functionality. Let's keep it this way.Hi @andreas.wolf@typo3.org, I hope it’s fine to classify this as a FEATURE, since you targeted main anyway and it’s clearly an improvement for our users.Login.html:43ReplyI have changed this to a button. -
core-ci voted on patch set 4 V +1 08/13/25, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83303
-
core-ci voted on patch set 3 V -1 08/13/25, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83302
-
Oli Bartsch updated the commit message in patch set 5
CR +1V +108/13/25, 16:26 -
Oli Bartsch voted on patch set 5 CR +1 V +1 08/13/25, 16:26
-
core-ci voted on patch set 5 V +1 08/13/25, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83315
-
Christian Kuhn voted on patch set 5 CR +1 V +1 08/15/25, 08:56
-
Oli Bartsch voted on patch set 5 CR +2 V +2 08/15/25, 09:02
-
Oli Bartsch merged patch set 6 08/15/25, 09:02