90310[TASK] Use DI in ViewHelpers
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 27
- typo3/sysext/backend/Classes/ViewHelpers/Link/EditRecordViewHelper.php+7 −2
- typo3/sysext/backend/Classes/ViewHelpers/Link/NewRecordViewHelper.php+7 −3
- typo3/sysext/backend/Classes/ViewHelpers/Uri/EditRecordViewHelper.php+5 −2
- typo3/sysext/backend/Classes/ViewHelpers/Uri/NewRecordViewHelper.php+7 −3
- typo3/sysext/backend/Classes/ViewHelpers/AvatarViewHelper.php+5 −1
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLinkViewHelper.php+5 −2
- typo3/sysext/beuser/Classes/ViewHelpers/SpriteIconForRecordViewHelper.php+5 −3
- typo3/sysext/beuser/Classes/ViewHelpers/SwitchUserViewHelper.php+8 −4
- typo3/sysext/core/Classes/ViewHelpers/IconForRecordViewHelper.php+5 −3
- typo3/sysext/core/Classes/ViewHelpers/IconForResourceViewHelper.php+5 −3
- typo3/sysext/core/Tests/Functional/ViewHelpers/IconForRecordViewHelperTest.php+1 −14
- typo3/sysext/core/Tests/Functional/ViewHelpers/IconViewHelperTest.php+48 −78
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ReloadSqlDataViewHelper.php+8 −4
- typo3/sysext/extensionmanager/Classes/ViewHelpers/RemoveExtensionViewHelper.php+8 −3
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ToggleExtensionInstallationStateViewHelper.php+7 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Be/LinkViewHelper.php+7 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageInfoViewHelper.php+6 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php+1 −7
- typo3/sysext/fluid/Classes/ViewHelpers/Be/UriViewHelper.php+5 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Form/UploadDeleteCheckboxViewHelper.php4+10 −8
Show 7 more files
- typo3/sysext/fluid/Classes/ViewHelpers/Format/DateViewHelper.php+6 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Link/FileViewHelper.php+7 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Link/PageViewHelper.php+8 −3
- typo3/sysext/fluid/Classes/ViewHelpers/FlashMessagesViewHelper.php2+9 −3
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementErrorViewHelper.php+5 −2
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementPropertyViewHelper.php+5 −2
- typo3/sysext/redirects/Classes/ViewHelpers/TargetPageRecordViewHelper.php+5 −3
Review log 1927
Show 12 earlier messages
-
Simon Schaufelberger uploaded patch set 1 08/10/25, 15:30
-
core-ci voted on patch set 1 V +1 08/10/25, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83104
-
Oliver Klee voted on patch set 1 CR +1 08/10/25, 16:15
-
Simon Schaufelberger uploaded patch set 2
CR +1V +108/10/25, 16:29 -
Simon Schaufelberger uploaded patch set 3 08/10/25, 16:35
-
core-ci voted on patch set 2 V -1 08/10/25, 16:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83105
-
core-ci voted on patch set 3 V -1 08/10/25, 16:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83106
-
Simon Schaufelberger uploaded patch set 4
V -108/10/25, 20:11 -
core-ci voted on patch set 4 V -1 08/10/25, 20:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83107
-
Simon Schaufelberger uploaded patch set 5
V -108/10/25, 21:41 -
core-ci voted on patch set 5 V +1 08/10/25, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83108
-
Simon Schaufelberger commented on patch set 5 08/11/25, 00:58
-
Simon Schaufelberger uploaded patch set 6
V +108/11/25, 09:49 -
Simon Schaufelberger commented on patch set 5 08/11/25, 09:50
UploadDeleteCheckboxViewHelper.php:74ReplyDone -
core-ci voted on patch set 6 V +1 08/11/25, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83136
-
Oliver Klee voted on patch set 6 CR +1 V +1 08/11/25, 10:25
-
Simon Schaufelberger uploaded patch set 7
CR +1V +108/14/25, 13:25 -
core-ci voted on patch set 7 V +1 08/14/25, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83391
-
Jörg Bösche voted on patch set 7 CR +1 08/18/25, 10:30
-
Oliver Klee voted on patch set 7 CR +1 V +1 08/18/25, 11:08
-
Christian Kuhn commented on patch set 7 08/18/25, 15:01
FlashMessagesViewHelper.php:90i would opt to keep ExtensionService using makeInstance: This code path is optional, and ExtensionService is one of those ugly extbase classes that has a dependency to stateful configurationManager singleton. having this injected is kinda risky.UploadDeleteCheckboxViewHelper.php:70same here: hashService DI is fine, but lets keep ExtensionService using makeInstance, at least for now. -
Simon Schaufelberger uploaded patch set 8
CR +1V +108/18/25, 16:27 -
Simon Schaufelberger commented on patch set 8 08/18/25, 16:27
FlashMessagesViewHelper.php:90ReplyDoneUploadDeleteCheckboxViewHelper.php:70ReplyDone -
core-ci voted on patch set 8 V +1 08/18/25, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83575
-
Oliver Klee voted on patch set 8 CR +1 V +1 08/18/25, 16:46
-
Christian Kuhn voted on patch set 8 CR +2 V +2 08/18/25, 18:58
-
Christian Kuhn merged patch set 9 08/18/25, 18:58
UploadDeleteCheckboxViewHelper.php:74