90318[FEATURE] Introduce PSR-14 Event to modify options in EmailFinisher
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107256-PSR-14EventToModifyOptionsInEmailFinisher.rstnew+82 −0
- typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php2+8 −0
- typo3/sysext/form/Classes/Event/BeforeEmailFinisherInitializedEvent.phpnew+56 −0
- typo3/sysext/form/Tests/Functional/Domain/Finishers/EmailFinisherTest.phpnew+94 −0
Review log 2130
Show 45 earlier messages
-
Albrecht Köhnlein uploaded patch set 1 08/11/25, 13:26
-
Albrecht Köhnlein commented on patch set 1 08/11/25, 13:30
Question to core members: As this has no negativ impact, would there be a theoretical chance to also have this merged into 13.4? What could I do to make this possible? -
core-ci voted on patch set 1 V -1 08/11/25, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83145
-
Albrecht Köhnlein uploaded patch set 2
V -108/11/25, 13:55 -
Albrecht Köhnlein uploaded patch set 3 08/11/25, 14:03
-
core-ci voted on patch set 2 V -1 08/11/25, 14:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83146
-
Albrecht Köhnlein uploaded patch set 4 08/11/25, 14:10
-
core-ci voted on patch set 3 V -1 08/11/25, 14:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83147
-
core-ci voted on patch set 4 V +1 08/11/25, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83148
-
Josua Vogel commented on patch set 4 V -1 08/11/25, 15:07
I don't think there should be an event for this specific case. At most, I could imagine a general event for every finisher that allows you to manipulate the options. btw: we have written our own finishers for such special use cases. -
Albrecht Köhnlein commented on patch set 4 08/11/25, 15:12
Reply
There never can be too much events. They don't hurt anybody. And I also thought about a general event in `AbstractFinisher::execute()`. But then I decided to not propose it, because a inaccurate used event could cause to much trouble in all finishers by accident. In my opinion, having an explicit event is the better idea. -
Josua Vogel voted on patch set 4 V 0 08/11/25, 18:27
-
Oli Bartsch commented on patch set 4 08/12/25, 14:12
Reply
Since new Events require documentation and introduce new functionality, they are classified as Features and therefore cannot be backported. Recently, there have been discussions about whether Events might be an exception to this rule, but as of now, no such exception exists.Feature-107256-EmailFinisherPrepareOptionsEvent.rstPlease give a bit more context on the why and how. The Event class should be described and additionally code examples for easy adaptions should be added have a look at similar RSTs: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/14.0/Feature-99409-NewPSR-14BeforeLiveSearchFormIsBuiltEvent.html#feature-99409-new-psr-14-beforelivesearchformisbuiltevent https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/14.0/Feature-105624-PSR-14EventAfterBackendUserPasswordReset.html#feature-105624-psr-14-event-after-a-backend-user-password-has-been-reset https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.3/Feature-104168-PSR-14EventForModifyingCountries.html#feature-104168-psr-14-event-for-modifying-countries https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.3/Feature-104832-PSR-14EventToAlterTheResultsOfPageTreeRepository.html#feature-104832-psr-14-event-to-alter-the-results-of-pagetreerepository ...EmailFinisherPrepareOptionsEventTest.php:25Please doo not introduce unit tests for events. Let's add proper functional test. You could test the event itself but at least test that the event is actually dispatched in EmailFinisher ant that the result is used in further code. You can grep for "EventIsCalled()" to find similar tests. -
Albrecht Köhnlein uploaded patch set 5
V +108/12/25, 20:19 -
Albrecht Köhnlein uploaded patch set 6 08/12/25, 20:25
-
core-ci voted on patch set 5 V -1 08/12/25, 20:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83240
-
core-ci voted on patch set 6 V +1 08/12/25, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83242
-
Oli Bartsch uploaded patch set 7
V +108/12/25, 21:47 -
core-ci voted on patch set 7 V +1 08/12/25, 21:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83251
-
Oli Bartsch commented on patch set 7 CR +1 V +1 08/12/25, 22:00
Feature-107256-EmailFinisherPrepareOptionsEvent.rstReplyThanks! While I renamed the event to better match the existing ones, I've also adjusted the RST a bit to add more information.EmailFinisherPrepareOptionsEventTest.php:25ReplyDone -
Oli Bartsch updated the commit message in patch set 8
CR +1V +108/12/25, 22:02 -
Oli Bartsch voted on patch set 8 CR +1 V +1 08/12/25, 22:02
-
Christian Kuhn commented on patch set 7 CR -1 08/12/25, 22:03
EmailFinisher.php:63it is EventDispatcherInterface, is it? -
core-ci voted on patch set 8 V +1 08/12/25, 22:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83252
-
Oli Bartsch uploaded patch set 9
CR +1V +108/13/25, 06:04 -
Oli Bartsch commented on patch set 9 CR +1 V +1 08/13/25, 06:04
EmailFinisher.php:63ReplyOh, yes. Good Catch! -
core-ci voted on patch set 9 V +1 08/13/25, 06:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83272
-
Christian Kuhn voted on patch set 9 CR +1 08/13/25, 11:30
-
Benni Mack voted on patch set 9 CR +2 V +2 08/13/25, 17:16
-
Benni Mack merged patch set 10 08/13/25, 17:16