Review main Merged

90319[TASK] Improve confirm dialog buttons when changing record type

Oli Bartsch CR +2 V +2 Easy +13 −5 updated 08/12/25, 19:02

Commit message

When changing the type of a record, e.g. the
`doktype` of a page, a confirmation dialog is
displayed. The confirm button previously used
the generic label "OK", which is unclear for
a yes/no style question.

This patch replaces the generic button text
with dedicated labels for the confirm and cancel
actions. The confirm button now uses a label
describing the actual action: "Save and Refresh",
while the cancel button explicitly says "Keep editing".

This improves clarity and aligns with established UI
text guidelines for buttons and calls to action.

Refs: https://canvas.workday.com/guidelines/content/ui-text/buttons-and-calls-to-action

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 710

  1. Oli Bartsch uploaded patch set 1 08/11/25, 20:55

  2. core-ci voted on patch set 1 V -1 08/11/25, 21:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83154

  3. Oli Bartsch uploaded patch set 2 V -1 08/12/25, 06:57

  4. core-ci voted on patch set 2 V +1 08/12/25, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83175

  5. Garvin Hicking updated the commit message in patch set 3 V +1 08/12/25, 07:46

  6. Garvin Hicking voted on patch set 3 CR +1 V +1 08/12/25, 07:48

  7. core-ci voted on patch set 3 V +1 08/12/25, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83178

  8. Christian Kuhn voted on patch set 3 CR +1 V +1 08/12/25, 18:40

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 08/12/25, 18:55

  10. Christian Kuhn merged patch set 4 08/12/25, 19:02