Review main Merged

90341[TASK] Raise container image versions in `Build/Scripts/runTests.sh`

Stefan Bürk CR +2 V +2 Easy +7 −15 updated 08/13/25, 08:07

Commit message

This change updates the used image version in our
script dispatcher `Build/Scripts/runTests.sh`.

The now available newer npm in the image revelead
that the `package.json` and `package-lock.json`,
found when `npm ci` is executed.

This can be mitigated by executing `npm install`
effectly updating the lock file, which is done
now with this change.

Used command(s):

> Build/Scripts/runTests.sh -s cleanCache \
  && Build/Scripts/runTests.sh -s cleanBuild \
  && Build/Scripts/runTests.sh -s npm install \
  && Build/Scripts/runTests.sh -s npm ci

[1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/4273dc68494892a771067f53f644c9cb0b869d7e
[2] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/b4c7f90fdde38ebb6c9a3e12b2d302d17a3b84c0

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Christian Kuhn +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Christian Kuhn +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1317

  1. Stefan Bürk uploaded patch set 1 08/12/25, 10:55

  2. Stefan Bürk marked it work in progress 08/12/25, 11:00

  3. core-ci voted on patch set 1 V -1 08/12/25, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83195

  4. Stefan Bürk uploaded patch set 2 V -1 08/12/25, 11:13

  5. Stefan Bürk marked it ready for review 08/12/25, 11:15

  6. Stefan Bürk updated the commit message in patch set 3 08/12/25, 11:16

  7. core-ci voted on patch set 2 V +1 08/12/25, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83196

  8. core-ci voted on patch set 3 V +1 08/12/25, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83197

  9. core-ci commented on patch set 3 08/12/25, 11:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83198

  10. Oliver Klee voted on patch set 3 CR +1 V +1 08/12/25, 13:05

  11. Simon Schaufelberger voted on patch set 3 CR +1 V +1 08/12/25, 13:52

  12. Garvin Hicking voted on patch set 3 CR +1 V +1 08/12/25, 16:32

  13. Christian Kuhn voted on patch set 3 CR +1 V +1 08/12/25, 16:33

  14. Stefan Bürk voted on patch set 3 CR +2 V +2 08/12/25, 19:15

  15. Stefan Bürk merged patch set 4 08/12/25, 19:31

  16. Andreas Kienast commented on patch set 4 08/13/25, 07:51

    Unresolved

    Which node version is effectively in use now? Running `npm install` without runTests.sh reverts the changes in package-lock.json. I assume this patch would've needed adjustments in `Build/.nvmrc` as well.
  17. Benjamin Kott commented on patch set 4 08/13/25, 08:07

    Missing engine adaptions in package json and nvm: https://review.typo3.org/c/Packages/TYPO3.CMS/+/90368