Review main Merged

90349[TASK] Run unit tests with PHP 8.5

Christian Kuhn CR +2 V +2 Normal +38 −13 updated 08/12/25, 19:32

Commit message

PHP 8.5 is alpha4 now, we start adding it to CI.

The second argument to setlocale() is now strict 'string',
a set of tests is adapted to deal with that.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1018

  1. Christian Kuhn uploaded patch set 1 08/12/25, 16:33

  2. Christian Kuhn uploaded patch set 2 08/12/25, 16:37

  3. core-ci voted on patch set 1 V -1 08/12/25, 16:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83211

  4. Christian Kuhn uploaded patch set 3 08/12/25, 16:42

  5. core-ci voted on patch set 2 V -1 08/12/25, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83212

  6. core-ci voted on patch set 3 V +1 08/12/25, 16:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83214

  7. Christian Kuhn updated the commit message in patch set 4 V +1 08/12/25, 16:52

  8. Christian Kuhn uploaded patch set 5 08/12/25, 16:55

  9. core-ci voted on patch set 4 V +1 08/12/25, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83217

  10. Christian Kuhn uploaded patch set 6 08/12/25, 17:02

  11. core-ci voted on patch set 5 V +1 08/12/25, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83218

  12. core-ci voted on patch set 5 V +1 08/12/25, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83219

  13. core-ci voted on patch set 6 V +1 08/12/25, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83220

  14. core-ci commented on patch set 6 08/12/25, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83221

  15. Garvin Hicking voted on patch set 6 CR +1 V +1 08/12/25, 18:07

  16. Stefan Bürk voted on patch set 6 CR +1 V +1 08/12/25, 18:12

  17. Christian Kuhn voted on patch set 6 CR +2 V +2 08/12/25, 19:32

  18. Christian Kuhn merged patch set 7 08/12/25, 19:32