Review 13.4 Merged

90350[TASK] Run unit tests with PHP 8.5

Christian Kuhn CR +2 V +2 Normal +38 −13 updated 08/12/25, 19:32

Commit message

PHP 8.5 is alpha4 now, we start adding it to CI.

The second argument to setlocale() is now strict 'string',
a set of tests is adapted to deal with that.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 711

  1. Christian Kuhn uploaded patch set 1 08/12/25, 16:39

  2. Christian Kuhn uploaded patch set 2 08/12/25, 16:46

  3. core-ci voted on patch set 1 V -1 08/12/25, 16:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83213

  4. core-ci voted on patch set 2 V +1 08/12/25, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83215

  5. Christian Kuhn voted on patch set 2 CR -1 08/12/25, 16:56

  6. Christian Kuhn uploaded patch set 3 CR -1 V +1 08/12/25, 17:31

  7. core-ci voted on patch set 3 V +1 08/12/25, 17:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83222

  8. core-ci commented on patch set 3 08/12/25, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83223

  9. Garvin Hicking voted on patch set 3 CR +1 V +1 08/12/25, 18:08

  10. Christian Kuhn voted on patch set 3 CR +2 V +2 08/12/25, 19:32

  11. Christian Kuhn merged patch set 4 08/12/25, 19:32