Review 13.4 Merged

90354[TASK] Improve confirm dialog buttons when changing record type

Christian Kuhn CR +2 V +2 Easy +12 −4 updated 08/12/25, 19:03

Commit message

When changing the type of a record, e.g. the
`doktype` of a page, a confirmation dialog is
displayed. The confirm button previously used
the generic label "OK", which is unclear for
a yes/no style question.

This patch replaces the generic button text
with dedicated labels for the confirm and cancel
actions. The confirm button now uses a label
describing the actual action: "Save and Refresh",
while the cancel button explicitly says "Keep editing".

This improves clarity and aligns with established UI
text guidelines for buttons and calls to action.

Refs: https://canvas.workday.com/guidelines/content/ui-text/buttons-and-calls-to-action

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Christian Kuhn uploaded patch set 1 08/12/25, 18:54

  2. core-ci voted on patch set 1 V +1 08/12/25, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83230

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 08/12/25, 19:03

  4. Christian Kuhn merged patch set 2 08/12/25, 19:03