Review 13.4 Merged

90360[TASK] Resolve ignored `nullsafe.neverNull` PHPStan errors

Christian Kuhn CR +2 V +2 Easy +5 −35 updated 08/12/25, 20:15

Commit message

A nullsafe property access is not necessary if used in combination with
the null coalesce operator. This can be verified in the related PHPStan
issue https://github.com/phpstan/phpstan/issues/7109, where this
specific implementation detail was introduced.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 34

  1. Christian Kuhn uploaded patch set 1 08/12/25, 20:07

  2. core-ci voted on patch set 1 V +1 08/12/25, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83238

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 08/12/25, 20:15

  4. Christian Kuhn merged patch set 2 08/12/25, 20:15