Review main Ready for review Orphaned

90374[BUGFIX] Override type by query-parameter for urls with trailing slash

Ayke Halder CR -2 V -1 Normal +222 −1 updated 04/22/26, 10:33

Commit message

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 9
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/74/90374/9 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/74/90374/9 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -2 Blocked
    • Stefan Bürk -2
  • Verified V -1 Blocked
    • core-ci -1 CI

Relation chain 3

  1. main 90348[FEATURE] Add page type decorator for root-path Based on this change Abandoned Ayke Halder CR -2 V 0 → 13.4 Normal +229 −5
  2. 90374 [BUGFIX] Override type by query-parameter for urls with trailing slash This change

  3. main 90373[BUGFIX] Add trailing slash to url for unmapped page type This change is based on it Ayke Halder CR -2 V -1 → 14.3 Easy +39 −0

    The chain has patch set 4 of 5, the changes above it need a rebase.

Issues 2

Files 2

Review log 1221

  1. Ayke Halder uploaded patch set 1 08/13/25, 09:16

  2. Ayke Halder uploaded patch set 2 08/13/25, 09:19

  3. core-ci voted on patch set 1 V -1 08/13/25, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83283

  4. core-ci voted on patch set 2 V +1 08/13/25, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83284

  5. Ayke Halder uploaded patch set 3 V +1 08/13/25, 10:10

  6. Ayke Halder uploaded patch set 4 08/13/25, 10:30

  7. Ayke Halder uploaded patch set 5 08/13/25, 10:38

  8. core-ci voted on patch set 4 V -1 08/13/25, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83304

  9. core-ci voted on patch set 5 V -1 08/13/25, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83306

  10. core-ci voted on patch set 3 V -1 08/13/25, 11:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83300

  11. Ayke Halder uploaded patch set 6 V -1 08/14/25, 10:44

  12. core-ci voted on patch set 6 V -1 08/14/25, 10:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83378

  13. Ayke Halder uploaded patch set 7 V -1 08/14/25, 21:05

  14. Ayke Halder uploaded patch set 8 08/14/25, 21:06

  15. Ayke Halder marked it ready for review 08/14/25, 21:06

  16. core-ci voted on patch set 7 V +1 08/14/25, 21:13 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 8 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83408

  17. core-ci voted on patch set 8 V +1 08/14/25, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83409

  18. Stefan Bürk commented on patch set 8 CR -2 08/16/25, 22:53

    Unresolved

    Temp -2 -.- need to put more time in review this and the other commits in relation chain (next days)
  19. Oli Bartsch commented on patch set 8 08/17/25, 08:09

    Unresolved

    Please add more context about the why and how to the commit message. Just from the title, it's not really clear, what's happening here.
  20. Benni Mack updated the commit message in patch set 9 V +1 04/22/26, 06:33

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  21. core-ci voted on patch set 9 V -1 04/22/26, 07:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100729