Review main Abandoned

90375[BUGFIX] Let flatpickr handle timestamp values

Andreas Kienast CR 0 V -1 Easy +20 −7 updated 03/11/26, 16:25

Commit message

Using the localization state selector in combination with a date picker
now uses the real, user-facing input value to paste back the original
value and to toggle its `disabled` state. Since date values may be
stored as timestamps, flatpickr now checks for such values and converts
the to proper JavaScript `Date` objects.

Review

  • Code review CR 0
  • Verified V -1
    • Andreas Kienast -1
    • core-ci +1 CI

Issues 1

Files 5

Review log 58

  1. Andreas Kienast uploaded patch set 1 08/13/25, 09:32

  2. Andreas Kienast uploaded patch set 2 08/13/25, 09:32

  3. core-ci voted on patch set 1 V -1 08/13/25, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83285

  4. core-ci voted on patch set 2 V -1 08/13/25, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83286

  5. Andreas Kienast uploaded patch set 3 V -1 08/15/25, 07:35

  6. core-ci voted on patch set 3 V +1 08/15/25, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83440

  7. Andreas Kienast commented on patch set 3 V -1 08/15/25, 08:10

    Unresolved

    It's still not perfect... Example: have an empty `starttime` field, switch to "Custom value" and switch back to "Value of default language", the dummy value changes to "1970-01-01".
  8. Andreas Kienast abandoned the change 03/11/26, 16:25

    Not planning to work on this soon.