90378[TASK] Clarify various code issues in DataMapProcessor
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 5
- Build/phpstan/phpstan-baseline.neon+0 −24
- typo3/sysext/core/Classes/Database/RelationHandler.php+1 −1
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php+1 −1
- typo3/sysext/core/Classes/DataHandling/Localization/State.php2+10 −10
- typo3/sysext/core/Classes/DataHandling/PlainDataResolver.php+7 −9
Review log 912
-
Benni Mack uploaded patch set 1 08/13/25, 10:03
-
Benni Mack updated the commit message in patch set 2 08/13/25, 10:07
-
Oli Bartsch voted on patch set 2 CR +1 V +1 08/13/25, 10:31
-
core-ci voted on patch set 2 V +1 08/13/25, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83299
-
core-ci voted on patch set 1 V +1 08/13/25, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83296
-
Christian Kuhn commented on patch set 2 CR -1 08/13/25, 11:24
will updateState.php:94let's move class properties to top of class along the way. -
Christian Kuhn commented on patch set 2 08/13/25, 11:26
State.php:94ReplyDone -
Christian Kuhn uploaded patch set 3
CR +1V +108/13/25, 11:27 -
Christian Kuhn voted on patch set 3 CR +1 V +1 08/13/25, 11:27
-
core-ci voted on patch set 3 V +1 08/13/25, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83309
-
Oli Bartsch voted on patch set 3 CR +2 V +2 08/13/25, 11:55
-
Oli Bartsch merged patch set 4 08/13/25, 11:55