Review 12.4 Merged

90379[BUGFIX] Allow custom foreign_table_where for TCA type category in FlexForm

Nikita Hovratov CR +2 V +2 Normal +53 −4 updated 08/13/25, 17:15

Commit message

This fix has already been applied for normal TCA fields in #98656,
but was overlooked for FlexForm. In the meantime, FlexFormTools uses
TcaPreparation added in #104293 for v13 and above.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 4

Files 2

Review log 913

  1. Nikita Hovratov uploaded patch set 1 08/13/25, 11:09

  2. core-ci voted on patch set 1 V +1 08/13/25, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83308

  3. Oli Bartsch commented on patch set 1 08/13/25, 16:00

    Will add tests
  4. Oli Bartsch uploaded patch set 2 V +1 08/13/25, 16:01

  5. Oli Bartsch commented on patch set 2 08/13/25, 16:01

    Reply

    Done
  6. Oli Bartsch voted on patch set 2 CR +1 V +1 08/13/25, 16:02

  7. Nikita Hovratov commented on patch set 2 08/13/25, 16:02

    Reply

    Thanks <3
  8. core-ci voted on patch set 2 V -1 08/13/25, 16:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83314

  9. core-ci commented on patch set 2 08/13/25, 16:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83314

  10. core-ci voted on patch set 2 V +1 08/13/25, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83314

  11. Benni Mack voted on patch set 2 CR +1 V +1 08/13/25, 17:14

  12. Benni Mack voted on patch set 2 CR +2 V +2 08/13/25, 17:15

  13. Benni Mack merged patch set 3 08/13/25, 17:15