Review main Merged

90384[BUGFIX] Ensure invalid pages should not stop DataHandler

Benni Mack CR +2 V +2 Easy +35 −3 updated 09/14/26, 06:48

Commit message

When working in Workspaces, with redirects or
other parts where an editor does not have access
to a page, BE_USER->isInWebMount throws a RuntimeException.

This is really bad when dealing with workspaces,
e.g. interrupting the publishing process.

The exception is caught in this one place, and continued
further.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1619

  1. Benni Mack uploaded patch set 1 08/13/25, 22:31

  2. core-ci voted on patch set 1 V +1 08/13/25, 22:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83331

  3. Sebastian Iffland voted on patch set 1 CR +1 V +1 09/12/25, 06:59

  4. Garvin Hicking commented on patch set 1 09/17/25, 19:11

  5. Josef Glatz commented on patch set 1 V -1 11/11/25, 05:52

  6. Peter Kraume commented on patch set 1 V -1 03/30/26, 21:41

    I have tested this patch in combination with the error which is described here: https://forge.typo3.org/issues/107432 The patch stops the immediate exception. But TYPO3 still thows two errors: 1: Attempt to create workspace version of "sys_file_metadata:54" without read permissionsand 1: Attempt to version record "sys_file_metadata:54" failed [Online record was not in a workspace]And of course nothing is persisted in the database.
  7. Benni Mack uploaded patch set 2 CR +1 V +1 04/21/26, 14:42

  8. Benni Mack marked it ready for review 04/21/26, 14:42

  9. core-ci voted on patch set 2 V +1 04/21/26, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100654

  10. Sebastian Iffland voted on patch set 2 CR +1 04/21/26, 15:28

  11. Christian Kuhn commented on patch set 2 04/21/26, 15:49

    Reply

    this is probably a different issue, and i think i've read something about broken sys_file_metadata access stuff elsewhere, too.

    BackendUserAuthentication.php:368

    i'd say we could just go ahead and turn this into something specific right away: even with a specific exception not inheriting \runtimeE, this shouldn't be considered breaking.
  12. Christian Kuhn wrote 06/18/26, 23:04

    Removed cc Christian Kuhn.
  13. Benni Mack uploaded patch set 3 CR +1 V +1 09/11/26, 22:51

  14. core-ci voted on patch set 3 V +1 09/11/26, 23:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108358

  15. Benni Mack commented on patch set 3 09/12/26, 08:49

    Reply

    Done

    BackendUserAuthentication.php:368 Reply

    Done
  16. Simon Schaufelberger voted on patch set 3 CR +1 V +1 09/12/26, 23:09

  17. Georg Ringer voted on patch set 3 CR +1 V +1 09/13/26, 11:53

  18. Benni Mack voted on patch set 3 CR +2 V +2 09/14/26, 06:48

  19. Benni Mack merged patch set 4 09/14/26, 06:48