90384[BUGFIX] Ensure invalid pages should not stop DataHandler
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1619
-
Benni Mack uploaded patch set 1 08/13/25, 22:31
-
core-ci voted on patch set 1 V +1 08/13/25, 22:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83331
-
Sebastian Iffland voted on patch set 1 CR +1 V +1 09/12/25, 06:59
-
Garvin Hicking commented on patch set 1 09/17/25, 19:11
please see https://forge.typo3.org/issues/107103#change-549033 for a comment -
Josef Glatz commented on patch set 1 V -1 11/11/25, 05:52
I can reproduce https://forge.typo3.org/issues/107103#note-7 from Kay. -
Peter Kraume commented on patch set 1 V -1 03/30/26, 21:41
I have tested this patch in combination with the error which is described here: https://forge.typo3.org/issues/107432 The patch stops the immediate exception. But TYPO3 still thows two errors: 1: Attempt to create workspace version of "sys_file_metadata:54" without read permissionsand 1: Attempt to version record "sys_file_metadata:54" failed [Online record was not in a workspace]And of course nothing is persisted in the database. -
Benni Mack uploaded patch set 2
CR +1V +104/21/26, 14:42 -
Benni Mack marked it ready for review 04/21/26, 14:42
-
core-ci voted on patch set 2 V +1 04/21/26, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100654
-
Sebastian Iffland voted on patch set 2 CR +1 04/21/26, 15:28
-
Christian Kuhn commented on patch set 2 04/21/26, 15:49
Reply
this is probably a different issue, and i think i've read something about broken sys_file_metadata access stuff elsewhere, too.BackendUserAuthentication.php:368i'd say we could just go ahead and turn this into something specific right away: even with a specific exception not inheriting \runtimeE, this shouldn't be considered breaking. -
Christian Kuhn wrote 06/18/26, 23:04
Removed cc Christian Kuhn. -
Benni Mack uploaded patch set 3
CR +1V +109/11/26, 22:51 -
core-ci voted on patch set 3 V +1 09/11/26, 23:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108358
-
Benni Mack commented on patch set 3 09/12/26, 08:49
Reply
DoneBackendUserAuthentication.php:368ReplyDone -
Simon Schaufelberger voted on patch set 3 CR +1 V +1 09/12/26, 23:09
-
Georg Ringer voted on patch set 3 CR +1 V +1 09/13/26, 11:53
-
Benni Mack voted on patch set 3 CR +2 V +2 09/14/26, 06:48
-
Benni Mack merged patch set 4 09/14/26, 06:48