Review main Merged

90391[BUGFIX] Cast possible record type int to string in TCA userfunc

Christian Kuhn CR +2 V +2 Easy +19 −5 updated 08/14/25, 10:33

Commit message

TCA record types can historically still look like ints: For
example the usually unused 'default' record type '1' in
tt_content.

When these are used as array keys, PHP turns them into ints.
Feeding this to TCA schema may then throws PHP exceptions
since TCA schema like hasSubSchema() and getSubSchema() expect
strings only.

The patch adds a string cast to avoid exceptions.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 811

  1. Christian Kuhn uploaded patch set 1 08/14/25, 09:51

  2. core-ci voted on patch set 1 V +1 08/14/25, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83370

  3. Garvin Hicking updated the commit message in patch set 2 V +1 08/14/25, 10:12

  4. Garvin Hicking voted on patch set 2 CR +1 V +1 08/14/25, 10:12

  5. Oli Bartsch uploaded patch set 3 CR +1 V +1 08/14/25, 10:15

  6. Oli Bartsch voted on patch set 3 CR +1 V +1 08/14/25, 10:15

  7. Benni Mack voted on patch set 3 CR +1 V +1 08/14/25, 10:16

  8. core-ci voted on patch set 2 V +1 08/14/25, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83374

  9. core-ci voted on patch set 3 V +1 08/14/25, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83375

  10. Christian Kuhn voted on patch set 3 CR +2 V +2 08/14/25, 10:33

  11. Christian Kuhn merged patch set 4 08/14/25, 10:33