Review main Merged

90396[TASK] CGL: Have basic ordered_class_elements rule

Christian Kuhn CR +2 V +2 Hard +278 −293 updated 08/14/25, 18:35

Commit message

When looking at classes, it is especially ugly when class
properties are buried somewhere between methods and do not
appear in the "header" part of the class.

The patch configures php-cs-fixer ordered_class_elements:
use (traits), case (enum), constants, properties.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 53

Show 33 more files

Review log 56

  1. Christian Kuhn uploaded patch set 1 08/14/25, 12:28

  2. core-ci voted on patch set 1 V +1 08/14/25, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83389

  3. Oliver Klee voted on patch set 1 CR +1 V +1 08/14/25, 13:21

  4. Oli Bartsch voted on patch set 1 CR +1 V +1 08/14/25, 13:36

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 08/14/25, 13:36

  6. Christian Kuhn merged patch set 2 08/14/25, 18:35