90400[TASK] Add `getSoftReferenceKeys()` method to Schema Field API
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 30
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+4 −3
- typo3/sysext/core/Classes/Schema/Field/AbstractFieldType.php+10 −0
- typo3/sysext/core/Classes/Schema/Field/CategoryFieldType.php1+5 −0
- typo3/sysext/core/Classes/Schema/Field/CheckboxFieldType.php+4 −0
- typo3/sysext/core/Classes/Schema/Field/ColorFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/CountryFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/DateTimeFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/EmailFieldType.php+0 −1
- typo3/sysext/core/Classes/Schema/Field/FieldTypeInterface.php+1 −0
- typo3/sysext/core/Classes/Schema/Field/FileFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/FlexFormFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/FolderFieldType.php+4 −0
- typo3/sysext/core/Classes/Schema/Field/GroupFieldType.php+4 −0
- typo3/sysext/core/Classes/Schema/Field/ImageManipulationFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/InlineFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/JsonFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/LanguageFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/NoneFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/NumberFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/PassthroughFieldType.php+5 −0
Show 10 more files
- typo3/sysext/core/Classes/Schema/Field/PasswordFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/RadioFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/SelectRelationFieldType.php+4 −0
- typo3/sysext/core/Classes/Schema/Field/SlugFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/StaticSelectFieldType.php+0 −1
- typo3/sysext/core/Classes/Schema/Field/SystemInternalFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/UserFieldType.php+4 −0
- typo3/sysext/core/Classes/Schema/Field/UuidFieldType.php+5 −0
- typo3/sysext/core/Tests/Unit/Schema/Field/FieldTypeSoftReferenceTest.phpnew+152 −0
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php+3 −2
Review log 1319
-
Oli Bartsch uploaded patch set 1 08/14/25, 15:06
-
Oli Bartsch updated the commit message in patch set 2 08/14/25, 15:06
-
Mathias Brodala commented on patch set 2 08/14/25, 15:10
Do we need "false"? Would an empty array as return value not work equally well? -
core-ci voted on patch set 1 V -1 08/14/25, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83396
-
core-ci voted on patch set 2 V -1 08/14/25, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83397
-
Oli Bartsch uploaded patch set 3
V -108/14/25, 15:17 -
core-ci voted on patch set 3 V +1 08/14/25, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83399
-
Oli Bartsch uploaded patch set 4
V +108/14/25, 15:28 -
Oli Bartsch commented on patch set 4 08/14/25, 15:30
Reply
Hi Mathias, the `false` case is explicit needed for better distinction, see the updated commit message. -
core-ci voted on patch set 4 V +1 08/14/25, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83400
-
Oli Bartsch uploaded patch set 5
V +108/14/25, 21:46 -
core-ci voted on patch set 5 V -1 08/14/25, 21:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83414
-
Oli Bartsch uploaded patch set 6
V -108/15/25, 08:47 -
core-ci voted on patch set 6 V +1 08/15/25, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83441
-
Benni Mack voted on patch set 6 CR +1 V +1 08/15/25, 10:35
-
Stefan Bürk commented on patch set 6 08/15/25, 12:58
CategoryFieldType.php:60I'm not sure with making return type stricter in extending types only returning false. That gives consumers with static code anlyzers headaches to work around without real benefit - an we are going to shoot us in our own foot in the future: https://phpstan.org/r/976aec84-5b36-4927-9e74-8e251b817b53 As soon as the "concrete" type is clear, like CategoryFieldType callint that method as part of a condition is considered use-less by phpstan (and I guess psalm too) as it always returns false ... which makes that metod with the interface only usable as the interface is the annotated type and not resolved. Just commenting it here ... that has not been taking into account for other methods and apis already and I guess we need to think about that more in general for the future about the caveats, for ourself but also extension developers. Not taking that now as an blocker. -
Stefan Bürk voted on patch set 6 CR +1 V +1 08/15/25, 12:58
-
Oli Bartsch voted on patch set 6 CR +2 V +2 08/15/25, 13:17
-
Oli Bartsch merged patch set 7 08/15/25, 13:17