Review main Merged

90408[BUGFIX] Re-introduce "danger" severity for CacheAction array shape

Moritz Ngo CR +2 V +2 Easy +1 −1 updated 08/16/25, 07:14

Commit message

#107185 introduced the CacheAction array shape, defined in
`ClearCacheToolbarItem`. Those changes specified some but
not all severities. The missing string "danger" is added
now, since it is being used in this same class for clearing
all caches (['cacheCmd' => 'all']).

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 911

  1. Moritz Ngo uploaded patch set 1 08/15/25, 11:56

  2. Moritz Ngo marked it ready for review 08/15/25, 11:57

  3. core-ci voted on patch set 1 V +1 08/15/25, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83451

  4. Oli Bartsch updated the commit message in patch set 2 V +1 08/15/25, 14:52

  5. Oli Bartsch voted on patch set 2 CR +1 V +1 08/15/25, 14:53

  6. core-ci voted on patch set 2 V +1 08/15/25, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83464

  7. Garvin Hicking commented on patch set 2 CR +1 V +1 08/15/25, 21:48

    ClearCacheToolbarItem.php:91

    Does phpstan only catch this on bigher levels to spot this mismatched the earlier shale?!
  8. Christian Kuhn commented on patch set 2 CR +1 V +1 08/15/25, 23:19

    ClearCacheToolbarItem.php:91 Reply

    probably, yes?
  9. Garvin Hicking voted on patch set 2 CR +2 V +2 08/16/25, 07:06

  10. Oliver Klee voted on patch set 2 CR +1 08/16/25, 07:09

  11. Garvin Hicking merged patch set 3 08/16/25, 07:14