Review 12.4 Merged

90411[BUGFIX] Avoid PHP errors with broken FE URL arguments

Christian Weiske CR +2 V +2 Easy +17 −10 updated 08/22/25, 15:29

Commit message

When 'type', 'cHash' or '__RequestToken' URL arguments
are arrays, FE triggers 'Array to string conversion'
warning level PHP errors. TYPO3 never creates such links,
this is usually "external manipulation". Still, the FE
should not crash on this. The patch sanitizes these
cases.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Christian Weiske uploaded patch set 1 08/15/25, 12:42

  2. Christian Weiske commented on patch set 1 08/15/25, 12:43

    Backport of the patch to v12. I picked only the validation changes - not the changes to the PageArgumentValidator constructor signature or the test changes needed for the signature change.
  3. core-ci voted on patch set 1 V +1 08/15/25, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83455

  4. Benni Mack updated the commit message in patch set 2 V +1 08/15/25, 14:41

  5. core-ci voted on patch set 2 V +1 08/15/25, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83462

  6. Christian Kuhn commented on patch set 2 CR +2 V +2 08/22/25, 15:29

    ok. this should be fine in v12 as well and can prevent polluting log with FE related crashes when invalid data is sent. will merge no.
  7. Christian Kuhn merged patch set 3 08/22/25, 15:29