Review 12.4 Merged

90422[TASK] Remove deprecated function calls with no effect since PHP 8.0

Stefan Bürk CR +2 V +2 Easy +1 −30 updated 08/17/25, 22:32

Commit message

Following function calls have been deprecated with PHP 8.5 as
they have no effect since PHP 8.0:

* `xml_parser_free()`
* `imagedestroy()`

From [1]:

*   xml_parser_create() and xml_parser_create_ns() will now return an
    XMLParser object rather than a resource. The xml_parser_free()
    function no longer has an effect, instead the XMLParser instance
    is automatically destroyed if it is no longer referenced.

*   The GD extension now uses GdImage objects as the underlying data
    structure for images, rather than resources. The imagedestroy()
    function no longer has an effect; instead the GdImage instance
    is automatically destroyed if it is no longer referenced.

Method calls are simply removed considering it makes no difference.

[1] https://www.php.net/manual/en/migration80.incompatible.php

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Simon Praetorius +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 79

  1. Stefan Bürk uploaded patch set 1 08/16/25, 13:31

  2. core-ci voted on patch set 1 V +1 08/16/25, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83502

  3. Garvin Hicking updated the commit message in patch set 2 V +1 08/16/25, 16:14

  4. Garvin Hicking voted on patch set 2 CR +1 V +1 08/16/25, 16:15

  5. core-ci voted on patch set 2 V +1 08/16/25, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83506

  6. Simon Praetorius voted on patch set 2 CR +1 V +1 08/17/25, 06:53

  7. Oliver Klee voted on patch set 2 CR +1 V +1 08/17/25, 07:55

  8. Stefan Bürk voted on patch set 2 CR +2 V +2 08/17/25, 22:32

  9. Stefan Bürk merged patch set 3 08/17/25, 22:32