Review 13.4 Merged

90425[BUGFIX] Remove defaults from required ViewHelper arguments

Simon Praetorius CR +2 V +2 Easy +43 −3 updated 08/17/25, 13:29

Commit message

ViewHelper arguments can either be optional, in which case a
default value can be defined, or they can be required, then
without a default.

This patch adjusts two ViewHelpers where arguments have
been defined as required with a default value. This change
doesn't have any effect on the behavior of the ViewHelpers,
as the requirement is always checked by Fluid, even if a
default value is specified (which is ignored in that case).
With Fluid 5, this misconfiguration will lead to a proper
exception.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
  • Verified V +2 Done
    • Simon Praetorius +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Simon Praetorius commented on patch set 1 08/17/25, 13:15

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 08/17/25, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83530

  3. Simon Praetorius voted on patch set 1 CR +2 V +2 08/17/25, 13:29

  4. Simon Praetorius merged patch set 2 08/17/25, 13:29