Review main Merged

90426[BUGFIX] Don't rely on Fluid namespace inheritance

Simon Praetorius CR +2 V +2 Easy +9 −0 updated 08/18/25, 07:07

Commit message

Up until Fluid v4, Fluid inherits ViewHelper namespaces imported in
the main template to partials. This feature has been deprecated
with Fluid v4 and will no longer work with Fluid v5.

In the core, there are only a few templates remaining that
(accidentally) don't import all required namespaces (global
namespaces not including). This patch adds the missing
local namespace imports to the affected templates to
avoid deprecations in v13 and exceptions in v14.

Related Fluid changes:

https://github.com/TYPO3/Fluid/pull/1080
https://github.com/TYPO3/Fluid/pull/1154

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Simon Schaufelberger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1316

  1. Simon Praetorius uploaded patch set 1 08/17/25, 13:27

  2. core-ci voted on patch set 1 V +1 08/17/25, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83531

  3. Garvin Hicking commented on patch set 1 08/17/25, 15:14

    LanguageColumns.html:2

    how about closing `<html>` too, while whe're at it?
  4. Stefan Bürk commented on patch set 2 V +1 08/17/25, 16:15

    Published edit on patch set 1.
  5. Stefan Bürk uploaded patch set 3 08/17/25, 16:16

  6. Stefan Bürk commented on patch set 3 CR +1 V +1 08/17/25, 16:18

    LanguageColumns.html:2 Reply

    Done
  7. core-ci voted on patch set 2 V -1 08/17/25, 16:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83535

  8. core-ci voted on patch set 3 V +1 08/17/25, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83536

  9. Garvin Hicking voted on patch set 3 CR +1 V +1 08/17/25, 19:31

  10. Benni Mack voted on patch set 3 CR +1 08/17/25, 19:53

  11. Simon Schaufelberger voted on patch set 3 CR +1 V +1 08/17/25, 19:58

  12. Simon Schaufelberger commented on patch set 3 08/17/25, 20:00

    Once upon a time I actually created an issue and this patch here is partially the same now: https://forge.typo3.org/issues/103270
  13. Christian Kuhn voted on patch set 3 CR +1 V +1 08/17/25, 21:16

  14. Simon Praetorius voted on patch set 3 CR +2 V +2 08/18/25, 07:06

  15. Simon Praetorius merged patch set 4 08/18/25, 07:07

  16. Simon Praetorius commented on patch set 4 08/18/25, 07:07

    Reply

    Done