Review 13.4 Merged

90427[BUGFIX] Don't rely on Fluid namespace inheritance

Simon Praetorius CR +2 V +2 Easy +10 −0 updated 08/18/25, 07:07

Commit message

Up until Fluid v4, Fluid inherits ViewHelper namespaces imported in
the main template to partials. This feature has been deprecated
with Fluid v4 and will no longer work with Fluid v5.

In the core, there are only a few templates remaining that
(accidentally) don't import all required namespaces (global
namespaces not including). This patch adds the missing
local namespace imports to the affected templates to
avoid deprecations in v13 and exceptions in v14.

Related Fluid changes:

https://github.com/TYPO3/Fluid/pull/1080
https://github.com/TYPO3/Fluid/pull/1154

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Simon Praetorius uploaded patch set 1 08/17/25, 13:34

  2. core-ci voted on patch set 1 V +1 08/17/25, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83532

  3. Stefan Bürk uploaded patch set 2 V +1 08/17/25, 16:18

  4. Stefan Bürk voted on patch set 2 CR +1 V +1 08/17/25, 16:19

  5. core-ci voted on patch set 2 V +1 08/17/25, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83537

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 08/17/25, 21:16

  7. Simon Praetorius voted on patch set 2 CR +2 V +2 08/18/25, 07:07

  8. Simon Praetorius merged patch set 3 08/18/25, 07:07