Review 13.4 Merged

90432[BUGFIX] Consider content object cache lifetimes in HTTP cache headers

Christian Kuhn CR +2 V +2 Normal +53 −15 updated 08/18/25, 12:55

Commit message

The page cache timeout calculation did not consider content-specific
cache lifetimes when no cache tag is given.

This caused situations where content objects with shorter cache
lifetimes (e.g. lib.content.cache.lifetime = 3600) would not affect
the HTTP max-age header, leading to incorrect client-side caching.

When no cache tags are defined, we now restrict the maximum lifetime
to the corresponding cache tag lifetime. Due to differences in how
cache backends handle lifetimes, we cannot alter the existing
calculation logic. instead, a new calculation method for cache
tag lifetimes has been introduced.

Additionally, this change fixes an unrelated issue by ensuring
that the "default" cache lifetime value is handled correctly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Christian Kuhn commented on patch set 1 08/18/25, 12:33

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 08/18/25, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83567

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 08/18/25, 12:55

  4. Christian Kuhn merged patch set 2 08/18/25, 12:55