Review main Merged

90433[BUGFIX] Align cache backend lifetime with HTTP cache headers

Sascha Nowak CR +2 V +2 Easy +9 −23 updated 08/19/25, 12:21

Commit message

The cache backend is currently allowed to define the effective
lifetime of a cache entry, which can cause inconsistencies
between the stored entry and the Cache-Control header.

When the lifetime parameter is null, the CacheBackend falls
back to defaultLifetime, which is configurable by the user.
This requires the backend lifetime and the cache_period in
TypoScript to be kept in sync.

Additionally, a lifetime value of 0 is treated differently
by the cache backend, further contributing to inconsistent
cache behavior.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Sascha Nowak uploaded patch set 1 08/18/25, 15:39

  2. core-ci voted on patch set 1 V +1 08/18/25, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83573

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 08/18/25, 18:47

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 08/19/25, 12:21

  5. Stefan Bürk merged patch set 2 08/19/25, 12:21