Review main Merged Breaking

90434[!!!][TASK] Remove FreezableBackendInterface

Sascha Nowak CR +2 V +2 Hard +53 −257 updated 08/19/25, 11:36

Commit message

This change removes the FreezableBackendInterface and
its implementation in the FileBackend.

The interface methods were never used in the TYPO3 core
or in real-world projects. It originated from a backport
of the Flow implementation, where it was intended for proxy
class building.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Sascha Nowak +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Sascha Nowak +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1315

  1. Sascha Nowak uploaded patch set 1 08/18/25, 16:19

  2. core-ci voted on patch set 1 V +1 08/18/25, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83574

  3. Simon Schaufelberger commented on patch set 1 CR +1 V +1 08/18/25, 16:31

    Great that you found this dead code and thanks for the cleanup!
  4. Garvin Hicking commented on patch set 1 08/18/25, 18:42

    (This is "implemented", more likely through copy-pasta though, in EXT:staticfilecache in its current version)
  5. Christian Kuhn commented on patch set 1 08/18/25, 18:52

    Reply

    yeah, but it should be easy to adapt and probably be removed in the extension and still being v13 compatible.
  6. Christian Kuhn updated the commit message in patch set 2 CR +1 V +1 08/18/25, 18:52

  7. Christian Kuhn voted on patch set 2 CR +1 V +1 08/18/25, 18:52

  8. Garvin Hicking commented on patch set 2 08/18/25, 18:53

    Reply

    Sure; I just wanted to comment on the "no real-world" possibility. People probably copied this without knowing about its staleness, but then it still got "implemented". Fair game to remove this.
  9. core-ci voted on patch set 2 V +1 08/18/25, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83578

  10. Sascha Nowak commented on patch set 2 08/18/25, 19:10

    Reply

    yeah i found that in on staricfilecache too and i will make a pr when this one is merged and remove if there too as this extension seems widely used.
  11. Sascha Nowak voted on patch set 2 CR +1 V +1 08/18/25, 19:11

  12. Oliver Klee voted on patch set 2 CR +1 V +1 08/19/25, 07:33

  13. Simon Schaufelberger voted on patch set 2 CR +1 V +1 08/19/25, 07:37

  14. Stefan Bürk voted on patch set 2 CR +2 V +2 08/19/25, 11:36

  15. Stefan Bürk merged patch set 3 08/19/25, 11:36